From: Jeff King <peff@peff.net>
To: "Alejandro R. Sedeño" <asedeno@mit.edu>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Aleajndro R Sedeño" <asedeno@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+
Date: Wed, 5 Oct 2022 10:53:50 -0400 [thread overview]
Message-ID: <Yz2afjRezq5oGN4g@coredump.intra.peff.net> (raw)
In-Reply-To: <CAOO-Oz2WnodBnw86mi2GZ+jLGoGy_saX=kCpwPdm2xohDO1s_Q@mail.gmail.com>
On Mon, Oct 03, 2022 at 07:45:44PM -0400, Alejandro R. Sedeño wrote:
> I'm targeting an old SunOS 5.10 with a GCC 3.4.3, for reasons that can
> only be described as self-loathing. :-)
> The other users of GIT_GNUC_PREREQ are used for 2.8, and 3.1, so I
> figure distinguishing between 4.5+ and <4.5 should be well supported.
>
> Regardless, there's no reason to break older compilers over something
> that's this trivial to fix.
This will cause some mild hardships, as later patches will need to
#define UNUSED in other spots, as well, in order to get full coverage of
the code base (I have written those annotation patches, but they're not
applied upstream yet).
Still, I tend to agree with you that we should handle this case. It's
not too much work, and I should be able to work around the multiple
definitions by pulling it out into an unused.h or similar.
-Peff
next prev parent reply other threads:[~2022-10-05 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:23 [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+ Aleajndro R Sedeño
2022-10-03 22:25 ` brian m. carlson
2022-10-03 23:45 ` Alejandro R. Sedeño
2022-10-05 14:53 ` Jeff King [this message]
2022-10-06 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:16 ` Jeff King
2022-10-06 21:15 ` Ævar Arnfjörð Bjarmason
2022-10-11 0:22 ` Jeff King
[not found] ` <xmqqilkynd91.fsf@gitster.g>
2022-10-05 22:19 ` [PATCH] git-compat-util.h: GCC deprecated message arg only " Aleajndro R Sedeño
2022-10-06 7:31 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:24 ` Alejandro R. Sedeño
2022-10-05 22:22 ` [PATCH] git-compat-util.h: GCC deprecated only takes a message " Alejandro R. Sedeño
2022-10-06 7:33 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz2afjRezq5oGN4g@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).