From: "Aleajndro R Sedeño" <asedeno@google.com>
To: git@vger.kernel.org
Cc: "Alejandro R. Sedeño" <asedeno@mit.edu>,
"Alejandro R Sedeño" <asedeno@google.com>
Subject: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+
Date: Mon, 3 Oct 2022 17:23:18 -0400 [thread overview]
Message-ID: <20221003212318.3092010-1-asedeno@google.com> (raw)
From: Alejandro R. Sedeño <asedeno@mit.edu>
Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
---
git-compat-util.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index b90b64718e..045b47f83a 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -189,9 +189,12 @@ struct strbuf;
#define _NETBSD_SOURCE 1
#define _SGI_SOURCE 1
-#if defined(__GNUC__)
+#if GIT_GNUC_PREREQ(4, 5)
#define UNUSED __attribute__((unused)) \
__attribute__((deprecated ("parameter declared as UNUSED")))
+#elif defined(__GNUC__)
+#define UNUSED __attribute__((unused)) \
+ __attribute__((deprecated))
#else
#define UNUSED
#endif
--
2.38.0.rc1.362.ged0d419d3c-goog
next reply other threads:[~2022-10-03 21:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:23 Aleajndro R Sedeño [this message]
2022-10-03 22:25 ` [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+ brian m. carlson
2022-10-03 23:45 ` Alejandro R. Sedeño
2022-10-05 14:53 ` Jeff King
2022-10-06 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:16 ` Jeff King
2022-10-06 21:15 ` Ævar Arnfjörð Bjarmason
2022-10-11 0:22 ` Jeff King
[not found] ` <xmqqilkynd91.fsf@gitster.g>
2022-10-05 22:19 ` [PATCH] git-compat-util.h: GCC deprecated message arg only " Aleajndro R Sedeño
2022-10-06 7:31 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:24 ` Alejandro R. Sedeño
2022-10-05 22:22 ` [PATCH] git-compat-util.h: GCC deprecated only takes a message " Alejandro R. Sedeño
2022-10-06 7:33 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003212318.3092010-1-asedeno@google.com \
--to=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).