From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Alejandro R. Sedeño" <asedeno@mit.edu>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Aleajndro R Sedeño" <asedeno@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+
Date: Mon, 10 Oct 2022 20:22:52 -0400 [thread overview]
Message-ID: <Y0S3XDToBqnMr4/m@coredump.intra.peff.net> (raw)
In-Reply-To: <221006.86edvkr6cc.gmgdl@evledraar.gmail.com>
On Thu, Oct 06, 2022 at 11:15:16PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > But if the definition gets much more complicated, then it's probably
> > worth pulling it out rather than repeating it.
>
> Yeah, I've dealt with that pain before in other contexts. It would be
> great to have a git-compiler-compat.h with just the various
> __attribute__ stuff split off from git-compat-util.h.
I was going to just have unused.h, since I'd worry that piling too much
stuff into it will eventually hit a place where some compat/ code is
unhappy. But I'd also be OK to _start_ with the UNUSED definition, but
call it git-compiler-compat or something, and then people can migrate
things as they choose to test them.
> +TEST_BUILTINS_OBJS_NO_UNUSED += test-ctype.o
I'd rather not go that route. I already have an UNUSED-clean code base,
and once that is all merged we shouldn't need any of that complexity. In
the meantime, yes, people introduce new cases, but I am fixing those as
they do (and have been for a few years now).
-Peff
next prev parent reply other threads:[~2022-10-11 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:23 [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+ Aleajndro R Sedeño
2022-10-03 22:25 ` brian m. carlson
2022-10-03 23:45 ` Alejandro R. Sedeño
2022-10-05 14:53 ` Jeff King
2022-10-06 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:16 ` Jeff King
2022-10-06 21:15 ` Ævar Arnfjörð Bjarmason
2022-10-11 0:22 ` Jeff King [this message]
[not found] ` <xmqqilkynd91.fsf@gitster.g>
2022-10-05 22:19 ` [PATCH] git-compat-util.h: GCC deprecated message arg only " Aleajndro R Sedeño
2022-10-06 7:31 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:24 ` Alejandro R. Sedeño
2022-10-05 22:22 ` [PATCH] git-compat-util.h: GCC deprecated only takes a message " Alejandro R. Sedeño
2022-10-06 7:33 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0S3XDToBqnMr4/m@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).