* [bug] forcing build settings on rhel7 without specific checks is not appropriate
@ 2022-02-07 11:13 Alexander Kanavin
0 siblings, 0 replies; only message in thread
From: Alexander Kanavin @ 2022-02-07 11:13 UTC (permalink / raw)
To: git
Hello,
there was a recent change where a couple of compiler settings are
forced on rhel7:
# centos7/rhel7 provides gcc 4.8.5 and zlib 1.2.7.
ifneq ($(findstring .el7.,$(uname_R)),)
BASIC_CFLAGS += -std=c99
NO_UNCOMPRESS2 = YesPlease
endif
I believe this is not the right way to do it: the makefile should
check for the actual compiler and zstd versions and make the decision
based on that. Yocto project uses a much newer (cross)compiler and
zlib for cross-builds, and those settings are not only unnecessary,
but actively harm reproducibility, as cross-binaries built on
rhel7/centos7 are then not the same as binaries built on other
distributions. So we ended up reverting the change:
https://lists.openembedded.org/g/openembedded-core/message/161456
Thanks,
Alex
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-07 12:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 11:13 [bug] forcing build settings on rhel7 without specific checks is not appropriate Alexander Kanavin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).