From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=1.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 74A571F852 for ; Mon, 7 Feb 2022 12:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238489AbiBGMDS (ORCPT ); Mon, 7 Feb 2022 07:03:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358790AbiBGLOo (ORCPT ); Mon, 7 Feb 2022 06:14:44 -0500 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFDDEC0401DD for ; Mon, 7 Feb 2022 03:14:24 -0800 (PST) Received: by mail-ua1-x92e.google.com with SMTP id b37so22078322uad.12 for ; Mon, 07 Feb 2022 03:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=NTQ7XpbnbdODMC8eqeCRRMMZRTbSGsDzAHkJPEAfmjg=; b=oE8NEJ5M+KPdkhBZxynbEgHaVzmpkqdVWnPowcfh9LQDiVxlgtA7jK1s/TJE1eR1fh FUragkvlo4F49BrDrfC9q2XxmCFPX8Q3UwUFH2YwoFqSCu0ceyzULRKpdrPtoPa/CT8j BD9miS/TolF7GCUNGm1HxubddFlYGaBZynfknZMVZjZHkoq3Msz4RuIu0lzAh/+d3oCf UXtEAOBQdefW7z5E6N5kCkcw7GNjdtRFnYBSj5dC76TRz62bpZW5ioy1IqKSav+/Iz3k 9g/IR0Vos+9vAIIowI/3tfijy6K9WgXGVpdOI1BQ9tvNj8nCJNv90rauKhZV6cMOM3dR XpxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NTQ7XpbnbdODMC8eqeCRRMMZRTbSGsDzAHkJPEAfmjg=; b=zwH1eknlhHIBwlSWv101+9tT0rSg9s6PMXb/yemNOeN6Nkr79AuEdgVHONdjMvLJJ4 rPF0P9oh5V3DCVZi6y8oRA/r17QEYdAHv5AFyr0s+7MyLKmpHdF7zNmEbiPES4pmdFYt fVyVj3pSu71BSiqLlv4PEK+WDkD+6TmhnSqmVz5CgTvJQyvtA3nIbM89e5iOd1UPyFX2 d+UAuBwtlhFlao6i3FQrpQtX3hJ3zksFrX/Yia09K8us/KQ6bqe0M9EQM1PROr4IGSsx GnRpFp6TU3pLnbxM3n95W5hjyPLpYiizS3zvI97/XqFJn4N5/wZtW7/t5z6iujZ5f1dp /j+A== X-Gm-Message-State: AOAM533xUE9RBTRQqKu9hMu4EBqx86lGZeWkJsLqtxPSGD88Kt+GN12o 8bjucleLfxr/YSGUJEk15BFB7uc6fLzvcoowxC20YDWpYwQ= X-Google-Smtp-Source: ABdhPJybV32/U+2u7dJawVFjfAWNOvd2nrfmANFY+GehwOHmdqWOQxGID8nQctJE0kNxPQZCJEhSKW1WoANzhBmu7mw= X-Received: by 2002:ab0:604e:: with SMTP id o14mr3133867ual.71.1644232450044; Mon, 07 Feb 2022 03:14:10 -0800 (PST) MIME-Version: 1.0 From: Alexander Kanavin Date: Mon, 7 Feb 2022 12:13:59 +0100 Message-ID: Subject: [bug] forcing build settings on rhel7 without specific checks is not appropriate To: git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hello, there was a recent change where a couple of compiler settings are forced on rhel7: # centos7/rhel7 provides gcc 4.8.5 and zlib 1.2.7. ifneq ($(findstring .el7.,$(uname_R)),) BASIC_CFLAGS += -std=c99 NO_UNCOMPRESS2 = YesPlease endif I believe this is not the right way to do it: the makefile should check for the actual compiler and zstd versions and make the decision based on that. Yocto project uses a much newer (cross)compiler and zlib for cross-builds, and those settings are not only unnecessary, but actively harm reproducibility, as cross-binaries built on rhel7/centos7 are then not the same as binaries built on other distributions. So we ended up reverting the change: https://lists.openembedded.org/g/openembedded-core/message/161456 Thanks, Alex