git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: git@vger.kernel.org
Subject: [bug] forcing build settings on rhel7 without specific checks is not appropriate
Date: Mon, 7 Feb 2022 12:13:59 +0100	[thread overview]
Message-ID: <CANNYZj8L_-hhKGNvNfiSU4T2W0g8ZRJ-gJJ30PgRo=ycCGSObQ@mail.gmail.com> (raw)

Hello,

there was a recent change where a couple of compiler settings are
forced on rhel7:

# centos7/rhel7 provides gcc 4.8.5 and zlib 1.2.7.
ifneq ($(findstring .el7.,$(uname_R)),)
    BASIC_CFLAGS += -std=c99
    NO_UNCOMPRESS2 = YesPlease
endif

I believe this is not the right way to do it: the makefile should
check for the actual compiler and zstd versions and make the decision
based on that. Yocto project uses a much newer (cross)compiler and
zlib for cross-builds, and those settings are not only unnecessary,
but actively harm reproducibility, as cross-binaries built on
rhel7/centos7 are then not the same as binaries built on other
distributions. So we ended up reverting the change:
https://lists.openembedded.org/g/openembedded-core/message/161456

Thanks,
Alex

                 reply	other threads:[~2022-02-07 12:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANNYZj8L_-hhKGNvNfiSU4T2W0g8ZRJ-gJJ30PgRo=ycCGSObQ@mail.gmail.com' \
    --to=alex.kanavin@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).