From: Felipe Contreras <felipe.contreras@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
John Szakmeister <john@szakmeister.net>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
Date: Fri, 17 May 2013 12:02:58 -0500 [thread overview]
Message-ID: <CAMP44s2AGWk76Nwk+va-6SBZqj46AHf6d_tm-AeN8jWKR-mEvw@mail.gmail.com> (raw)
In-Reply-To: <vpqvc6hczq2.fsf@grenoble-inp.fr>
On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> THERE IS NO STYLE BREAKAGE.
>
> Repeating something, and even making it all caps does not make it true.
Tell that to Junio. He is also repeating the same.
I actually provided *evidence*. Did you miss it?
> You are wasting your time and everybody else's in this thread and many
> others. You seem to reject the very concept of code review. The Git
> community likes very much code review. I do not forsee a change in the
> taste for code review and iterations to make the code as clean as it can
> be in the Git community. And I'd hate to see it change because some
> contributors are too stubborn to send a reroll when someone else points
> out something in the patch.
Sorry, did I miss somebody mentioning a problem in this patch? All
I've seen is people throwing opinions, nothing related to this
project's coding style.
If you see this patch doesn't follow the project's style, please point
where, and where it's described in Documentation/CodingStyle.
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-17 17:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:16 [PATCH 0/4] trivial patches Felipe Contreras
2013-05-09 1:16 ` [PATCH 1/4] documentation: trivial style cleanups Felipe Contreras
2013-05-09 23:09 ` Junio C Hamano
2013-05-09 1:16 ` [PATCH 2/4] transport-helper: trivial style cleanup Felipe Contreras
2013-05-09 23:03 ` Junio C Hamano
2013-05-09 1:16 ` [PATCH 3/4] {fast-export,transport-helper}: style cleanups Felipe Contreras
2013-05-09 8:46 ` John Szakmeister
2013-05-09 8:50 ` Felipe Contreras
2013-05-09 9:30 ` John Szakmeister
2013-05-09 10:18 ` Felipe Contreras
2013-05-09 10:24 ` Ramkumar Ramachandra
2013-05-09 11:06 ` Felipe Contreras
2013-05-09 18:38 ` Junio C Hamano
2013-05-09 19:23 ` Felipe Contreras
2013-05-09 23:09 ` Junio C Hamano
2013-05-09 23:12 ` Felipe Contreras
2013-05-16 9:23 ` Felipe Contreras
2013-05-16 16:19 ` Junio C Hamano
2013-05-16 16:32 ` Felipe Contreras
2013-05-16 16:49 ` Junio C Hamano
2013-05-16 17:02 ` Felipe Contreras
2013-05-16 18:10 ` Junio C Hamano
2013-05-16 18:34 ` Ramkumar Ramachandra
2013-05-16 23:58 ` Felipe Contreras
2013-05-16 23:54 ` Felipe Contreras
2013-05-17 0:24 ` Felipe Contreras
2013-05-17 6:04 ` Ramkumar Ramachandra
2013-05-17 6:09 ` Felipe Contreras
2013-05-17 16:22 ` Junio C Hamano
2013-05-17 16:35 ` Felipe Contreras
2013-05-17 16:56 ` Matthieu Moy
2013-05-17 17:02 ` Felipe Contreras [this message]
2013-05-17 17:14 ` Matthieu Moy
2013-05-17 17:18 ` Felipe Contreras
2013-05-09 1:16 ` [PATCH 4/4] fast-export: trivial cleanup Felipe Contreras
2013-05-09 8:52 ` John Szakmeister
2013-05-09 8:53 ` Felipe Contreras
2013-05-09 9:04 ` John Szakmeister
2013-05-09 18:52 ` Junio C Hamano
2013-05-16 9:18 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2AGWk76Nwk+va-6SBZqj46AHf6d_tm-AeN8jWKR-mEvw@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@szakmeister.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).