From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: John Szakmeister <john@szakmeister.net>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
Date: Fri, 17 May 2013 09:22:17 -0700 [thread overview]
Message-ID: <7vobc91squ.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s2QcFStPtE8cSbH7jWvUOUVRSgGNYNVoDN6exRdW6xNYA@mail.gmail.com> (Felipe Contreras's message of "Thu, 16 May 2013 18:54:29 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> *You* are telling my that; it's *your* opinion and nothing else. It's
I saw a review comment that points out that the continuation lines
do not align, and you refused to say "ah, thanks for spotting" and
reroll [*1*], so even I do not want to do so in general, I had to
play the role of the arbiter.
My take on these style issues is this:
* People made mistakes in the past while doing real work. Big
news: contributors and reviewers are not perfect.
* They survived to this day because we do not do tree-wide "style
fixes" for the sake of style fix, in order to avoid clashing with
real work in flight.
* Existing mistakes are not an excuse for adding new mistakes of
the same kind, especially when they are pointed out during the
review (this is not limited to "style issues").
I do not think I would reject a patch with minor style bugs like
unaligned continuation lines, if it were a patch that does real
work.
But a "style cleanups" patch that introduces new instances of style
breakage is a different matter. It is clear that the original
(picked randomly):
die ("Encountered signed tag %s; use ",
"--signed-tags=<mode> to handle it.",
sha1_to_hex(tag->object.sha1));
wanted the opening double-quotes of two lines and the "sha1" at the
beginning of the third line to align. I see that is the local style
a "style cleanup" change should follow.
A patch that cleans up styles in preparation for a real work (like
this one) is a rare and precious occasion for us to really clean up
accumulated wart. I do not want to see existing mistakes from other
unrelated parts of the codebase that have not been cleaned up as an
excuse to waste that rare occasion to do a good job of cleaning up.
So that is the arbiter's decision. Call it *my* opinion or whatever
you like; it does not change anything.
[Footnote]
*1* That would have ended this thread without wasting everybody's
time.
next prev parent reply other threads:[~2013-05-17 16:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:16 [PATCH 0/4] trivial patches Felipe Contreras
2013-05-09 1:16 ` [PATCH 1/4] documentation: trivial style cleanups Felipe Contreras
2013-05-09 23:09 ` Junio C Hamano
2013-05-09 1:16 ` [PATCH 2/4] transport-helper: trivial style cleanup Felipe Contreras
2013-05-09 23:03 ` Junio C Hamano
2013-05-09 1:16 ` [PATCH 3/4] {fast-export,transport-helper}: style cleanups Felipe Contreras
2013-05-09 8:46 ` John Szakmeister
2013-05-09 8:50 ` Felipe Contreras
2013-05-09 9:30 ` John Szakmeister
2013-05-09 10:18 ` Felipe Contreras
2013-05-09 10:24 ` Ramkumar Ramachandra
2013-05-09 11:06 ` Felipe Contreras
2013-05-09 18:38 ` Junio C Hamano
2013-05-09 19:23 ` Felipe Contreras
2013-05-09 23:09 ` Junio C Hamano
2013-05-09 23:12 ` Felipe Contreras
2013-05-16 9:23 ` Felipe Contreras
2013-05-16 16:19 ` Junio C Hamano
2013-05-16 16:32 ` Felipe Contreras
2013-05-16 16:49 ` Junio C Hamano
2013-05-16 17:02 ` Felipe Contreras
2013-05-16 18:10 ` Junio C Hamano
2013-05-16 18:34 ` Ramkumar Ramachandra
2013-05-16 23:58 ` Felipe Contreras
2013-05-16 23:54 ` Felipe Contreras
2013-05-17 0:24 ` Felipe Contreras
2013-05-17 6:04 ` Ramkumar Ramachandra
2013-05-17 6:09 ` Felipe Contreras
2013-05-17 16:22 ` Junio C Hamano [this message]
2013-05-17 16:35 ` Felipe Contreras
2013-05-17 16:56 ` Matthieu Moy
2013-05-17 17:02 ` Felipe Contreras
2013-05-17 17:14 ` Matthieu Moy
2013-05-17 17:18 ` Felipe Contreras
2013-05-09 1:16 ` [PATCH 4/4] fast-export: trivial cleanup Felipe Contreras
2013-05-09 8:52 ` John Szakmeister
2013-05-09 8:53 ` Felipe Contreras
2013-05-09 9:04 ` John Szakmeister
2013-05-09 18:52 ` Junio C Hamano
2013-05-16 9:18 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobc91squ.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).