git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: John Szakmeister <john@szakmeister.net>,
	git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
Date: Thu, 16 May 2013 19:24:55 -0500	[thread overview]
Message-ID: <CAMP44s0PYreS7g8FfUW-3+9xY56-yiusKRcmUKHnZc4kDwXF-A@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s2QcFStPtE8cSbH7jWvUOUVRSgGNYNVoDN6exRdW6xNYA@mail.gmail.com>

On Thu, May 16, 2013 at 6:54 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:

> There are 535 instances where parenthesis are not aligned. Do you
> still think aligning open parenthesis is the "style of the project"?
>
> Please. You are rejecting this patch on a whim, and nothing more.

And FTR. I shouldn't need to waste my time demonstrating this obvious
fact to you, you should already know that the project doesn't follow
this style, and if you don't know for sure, you shouldn't act as if
you do. And even if you were correct, and this was the style of the
project, you should not reject patches based on unstated guidelines.

Would you think it's fair for you to go to jail for breaking a "law"
that is not written anywhere?

-- 
Felipe Contreras

  reply	other threads:[~2013-05-17  0:25 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  1:16 [PATCH 0/4] trivial patches Felipe Contreras
2013-05-09  1:16 ` [PATCH 1/4] documentation: trivial style cleanups Felipe Contreras
2013-05-09 23:09   ` Junio C Hamano
2013-05-09  1:16 ` [PATCH 2/4] transport-helper: trivial style cleanup Felipe Contreras
2013-05-09 23:03   ` Junio C Hamano
2013-05-09  1:16 ` [PATCH 3/4] {fast-export,transport-helper}: style cleanups Felipe Contreras
2013-05-09  8:46   ` John Szakmeister
2013-05-09  8:50     ` Felipe Contreras
2013-05-09  9:30       ` John Szakmeister
2013-05-09 10:18         ` Felipe Contreras
2013-05-09 10:24       ` Ramkumar Ramachandra
2013-05-09 11:06         ` Felipe Contreras
2013-05-09 18:38       ` Junio C Hamano
2013-05-09 19:23         ` Felipe Contreras
2013-05-09 23:09     ` Junio C Hamano
2013-05-09 23:12       ` Felipe Contreras
2013-05-16  9:23         ` Felipe Contreras
2013-05-16 16:19           ` Junio C Hamano
2013-05-16 16:32             ` Felipe Contreras
2013-05-16 16:49               ` Junio C Hamano
2013-05-16 17:02                 ` Felipe Contreras
2013-05-16 18:10                   ` Junio C Hamano
2013-05-16 18:34                     ` Ramkumar Ramachandra
2013-05-16 23:58                       ` Felipe Contreras
2013-05-16 23:54                     ` Felipe Contreras
2013-05-17  0:24                       ` Felipe Contreras [this message]
2013-05-17  6:04                       ` Ramkumar Ramachandra
2013-05-17  6:09                         ` Felipe Contreras
2013-05-17 16:22                       ` Junio C Hamano
2013-05-17 16:35                         ` Felipe Contreras
2013-05-17 16:56                           ` Matthieu Moy
2013-05-17 17:02                             ` Felipe Contreras
2013-05-17 17:14                               ` Matthieu Moy
2013-05-17 17:18                                 ` Felipe Contreras
2013-05-09  1:16 ` [PATCH 4/4] fast-export: trivial cleanup Felipe Contreras
2013-05-09  8:52   ` John Szakmeister
2013-05-09  8:53     ` Felipe Contreras
2013-05-09  9:04       ` John Szakmeister
2013-05-09 18:52         ` Junio C Hamano
2013-05-16  9:18   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMP44s0PYreS7g8FfUW-3+9xY56-yiusKRcmUKHnZc4kDwXF-A@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@szakmeister.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).