Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

[Junio C Hamano <gitster@pobox.com>]

John Szakmeister <john@szakmeister.net> writes:

> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>>  builtin/fast-export.c | 24 ++++++++++++------------
>>  1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
>> index d60d675..8091354 100644
>> --- a/builtin/fast-export.c
>> +++ b/builtin/fast-export.c
>> @@ -135,7 +135,7 @@ static void export_blob(const unsigned char *sha1)
> [snip]
>> @@ -289,13 +289,13 @@ static void handle_commit(struct commit *commit, struct rev_info *rev)
>>         parse_commit(commit);
>>         author = strstr(commit->buffer, "\nauthor ");
>>         if (!author)
>> -               die ("Could not find author in commit %s",
>> +               die("Could not find author in commit %s",
>>                      sha1_to_hex(commit->object.sha1));
>
> It looks like your simple replace didn't account for calls with
> multiple lines.  Now the remaining lines don't line up.
> :-)  There's several more places like this in the patch.

Good eyes.

Matching the coding-style to have no SP between function name and
its argument list is just as important as matching the indentation
style used in the project; trading one breakage with another does
not make much sense.