From: Tanay Abhra <tanayabh@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
Git List <git@vger.kernel.org>,
Matthieu Moy <git@matthieu-moy.fr>
Subject: Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404
Date: Fri, 12 Jan 2018 20:51:51 -0600 [thread overview]
Message-ID: <CAEc54XAP0jFuD4J_XUZOuHEBZ+6PceEQbpm7HJEtRt4NS7Lf2A@mail.gmail.com> (raw)
In-Reply-To: <xmqqy3l2ves2.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 12, 2018 at 5:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
>
> > Sadly, fixing the "except" thing causes the test to break now.
>
> That is exactly what I wanted to say. If you want to "fix" it,
> you'd need to figure out what the author of the "except" thing
> wanted to test, adjust the args given to test-config (it cannot be
> the same as the test-config invocation of the previous test), and
> then fix the typo s/except/expect/. Changing the typo alone *will*
> of course make the test fail, because then the file with the
> corrected name, i.e. "expect", has bogus lines that does not match
> how the current invocation of "test-config" command is expected to
> output.
Hi Guys,
I was the original author of the test, I am sorry about the typo.
I will submit a patch fixing the test. The fix can be checked at
https://github.com/git/git/pull/451.
'configset_get_value' will be changed to 'configset_get_value_multi'
since the test expects a list of values instead of a single value.
Thanks,
Tanay Abhra
next prev parent reply other threads:[~2018-01-13 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 19:42 [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404 Randall S. Becker
2018-01-12 22:07 ` Junio C Hamano
2018-01-12 23:10 ` Randall S. Becker
2018-01-12 23:27 ` Junio C Hamano
2018-01-13 2:51 ` Tanay Abhra [this message]
2018-01-16 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEc54XAP0jFuD4J_XUZOuHEBZ+6PceEQbpm7HJEtRt4NS7Lf2A@mail.gmail.com \
--to=tanayabh@gmail.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).