Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

[Junio C Hamano <gitster@pobox.com>]

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

> It looks like the exit code is coming back as 1 not 2. There is
> also a file except vs expect.
> ./trash directory.t1308-config-set: ls
> a-directory  actual  config2  except  expect  output  result

The test that leaves "except" does look wrong.  The relevant part
looks like this:

    test_expect_success 'find value with highest priority from a configset' '
            echo hask >expect &&
            test-config configset_get_value case.baz config2 .git/config >actual &&
            test_cmp expect actual
    '

    test_expect_success 'find value_list for a key from a configset' '
            cat >except <<-\EOF &&
            sam
            ...
            EOF
            test-config configset_get_value case.baz config2 .git/config >actual &&
            test_cmp expect actual
    '

The invocations of test-config in these two tests look exactly the
same, at least to me, so whatever comes out of the command and
stored in 'actual' must match what the first test stored in 'expect'
and compared the same as 'actual' in that test.

So the second test is probably asking a wrong question to test-config
but because it prepares an expected answer in a wrong file, it did
not even notice that it is asking a wrong question X-<.

The wrong test comes from 4c715ebb ("test-config: add tests for the
config_set API", 2014-07-28); I do not know offhand if the author of
that change is still around.

Having said all that, I suspect that the "except" thing may not have
anything to do with what you are observing; sorry for not ending up
to be very helpful X-<.