From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, "'Tanay Abhra'" <tanayabh@gmail.com>,
"'Matthieu Moy'" <git@matthieu-moy.fr>
Subject: RE: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404
Date: Fri, 12 Jan 2018 18:10:05 -0500 [thread overview]
Message-ID: <008f01d38bfa$7eba9bc0$7c2fd340$@nexbridge.com> (raw)
In-Reply-To: <xmqqd12ewx1v.fsf@gitster.mtv.corp.google.com>
On January 12, 2018 5:08 PM, Junio C Hamano wrote:
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
> > It looks like the exit code is coming back as 1 not 2. There is also a
> > file except vs expect.
> > ./trash directory.t1308-config-set: ls a-directory actual config2
> > except expect output result
>
> The test that leaves "except" does look wrong. The relevant part looks
like
> this:
>
> test_expect_success 'find value with highest priority from a
configset' '
> echo hask >expect &&
> test-config configset_get_value case.baz config2 .git/config
>actual &&
> test_cmp expect actual
> '
>
> test_expect_success 'find value_list for a key from a configset' '
> cat >except <<-\EOF &&
> sam
> ...
> EOF
> test-config configset_get_value case.baz config2 .git/config
>actual &&
> test_cmp expect actual
> '
>
> The invocations of test-config in these two tests look exactly the same,
at
> least to me, so whatever comes out of the command and stored in 'actual'
> must match what the first test stored in 'expect'
> and compared the same as 'actual' in that test.
>
> So the second test is probably asking a wrong question to test-config but
> because it prepares an expected answer in a wrong file, it did not even
> notice that it is asking a wrong question X-<.
>
> The wrong test comes from 4c715ebb ("test-config: add tests for the
> config_set API", 2014-07-28); I do not know offhand if the author of that
> change is still around.
>
> Having said all that, I suspect that the "except" thing may not have
anything
> to do with what you are observing; sorry for not ending up to be very
helpful
> X-<.
Sadly, fixing the "except" thing causes the test to break now. I can't make
sense of the intent of this, unless the test is to find unmatching keys and
it really does mean "except"
--- expect 2018-01-12 23:03:41 +0000
+++ actual 2018-01-12 23:03:41 +0000
@@ -1,5 +1 @@
-sam
-bat
hask
-lama
-ball
[case]
baz = lama
[my]
new = silk
[case]
baz = ball
next prev parent reply other threads:[~2018-01-12 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 19:42 [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404 Randall S. Becker
2018-01-12 22:07 ` Junio C Hamano
2018-01-12 23:10 ` Randall S. Becker [this message]
2018-01-12 23:27 ` Junio C Hamano
2018-01-13 2:51 ` Tanay Abhra
2018-01-16 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008f01d38bfa$7eba9bc0$7c2fd340$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).