RE: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

["Randall S. Becker" <rsbecker@nexbridge.com>]

On January 11, 2018 11:11 PM, Junio C Hamano wrote:
> A release candidate Git v2.16.0-rc2 is now available for testing at the usual
> places.  It is comprised of 483 non-merge commits since v2.15.0, contributed
> by 80 people, 23 of which are new faces.
<snip>

Please forgive my not knowing the proper way to report this ... we have a few breakages on the NonStop port (which has finally caught up to 2.16, yay!). The test run takes a very long time to run, so this is preliminary. I'm also not sure who should try to resolve these.

For 1308:

Value not found for "foo.bar"
not ok 23 - proper error on directory "files"
#
#               echo "Error (-1) reading configuration file a-directory." >expect &&
#               mkdir a-directory &&
#               test_expect_code 2 test-config configset_get_value foo.bar a-directory 2>output &&
#               grep "^warning:" output &&
#               grep "^Error" output >actual &&
#               test_cmp expect actual
test_expect_code: command exited with 1, we wanted 2 test-config configset_get_value foo.bar a-directory

It looks like the exit code is coming back as 1 not 2. There is also a file except vs expect.
./trash directory.t1308-config-set: ls
a-directory  actual  config2  except  expect  output  result

For 1404: It looks like the error was detected, but the test case was not structured to handle where the detection occurred. Here's what I see:

not ok 52 - delete fails cleanly if packed-refs file is locked
#
#               prefix=refs/locked-packed-refs &&
#               # Set up a reference with differing loose and packed versions:
#               git update-ref $prefix/foo $C &&
#               git pack-refs --all &&
#               git update-ref $prefix/foo $D &&
#               git for-each-ref $prefix >unchanged &&
#               # Now try to delete it while the `packed-refs` lock is held:
#               : >.git/packed-refs.lock &&
#               test_when_finished "rm -f .git/packed-refs.lock" &&
#               test_must_fail git update-ref -d $prefix/foo >out 2>err &&
#               git for-each-ref $prefix >actual &&
#               test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err &&
#               test_cmp unchanged actual
#

# failed 1 among 52 test(s)
1..52
./trash directory.t1404-update-ref-errors: ls
actual       commands  expected      expected-refs  out         unchanged
actual-refs  err       expected-err  input          output.err
./trash directory.t1404-update-ref-errors: cat err
error: Unable to create '/home/git/git/t/trash directory.t1404-update-ref-errors/.git/packed-refs.lock': File already exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.
./trash directory.t1404-update-ref-errors: cat out

Sincerely,
Randall

-- Brief whoami:
 NonStop developer since approximately 211288444200000000
 UNIX developer since approximately 421664400
-- In my real life, I talk too much.