From: Duy Nguyen <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
Jeff King <peff@peff.net>, Jeff Hostetler <git@jeffhostetler.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [RFC PATCH v1] telemetry design overview (part 1)
Date: Sat, 9 Jun 2018 09:31:57 +0200 [thread overview]
Message-ID: <CACsJy8DrtAdwH0dOjptJ0JDQ_gOeiTVbRknui4gM5P85Y5JZow@mail.gmail.com> (raw)
In-Reply-To: <87bmck4gip.fsf@evledraar.gmail.com>
On Sat, Jun 9, 2018 at 8:32 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> Let's say you're in a corporate environment with Linux, OSX and Windows
> boxes, but all of whom have some shared mounts provisioned & ability to
> ship an /etc/gitconfig (wherever that lives on Windows).
>
> It's much easier to just do that than figure out how to build a custom
> Git on all three platforms.
Let's say I don't care about making it easier on corporate
environment. You have resources to do that.
> > Not making it a compile-time option could force [1] linux distro
> > to carry this function to everybody even if they don't use it (and
> > it's kinda dangerous to misuse if you don't anonymize the data
> > properly). I also prefer this a compile time option.
>
> Setting GIT_TRACE to a filename that you published is also similarly
> dangerous, so would setting up a trivial 4-line shell alias to wrap
> "git" and log what it's doing.
>
> > [1] Of course many distros can choose to patch it out. But it's the
> > same argument as bringing this option in in the first place: you guys
> > already have that code in private and now want to put it in stock git
> > to reduce maintenance cost, why add extra cost on linux distro
> > maintenance?
>
> Because:
>
> 1) I really don't see the basis for this argument that they'd need to
> patch it out, they're not patching out e.g. GIT_TRACE now, which has
> all the same sort of concerns, it's just a format that's more of a
> hassle to parse than this proposed format.
>
> 2) I think you and Johannes are just seeing the "telemetry" part of
> this, but if you look past that all this *really* is is "GIT_TRACE
> facility that doesn't suck to parse".
If it's simply an improvement over GIT_TRACE, then I have no problem
with that. That is:
- there is no new, permanent way to turn this one like config keys
- there's no plugin support or whatever for keeping output. Keep it to
either a file or a file descriptor like we do with GIT_TRACE.
> There's a lot of use-cases for that which have nothing to do with
> what this facility is originally written for, for example, a novice
> git user could turn it on and have it log in ~ somewhere, and then
> run some contrib script which analyzes his git usage and spews out
> suggestions ("you use this command/option, but not this related
> useful command/option").
>
> Users asking for help on the #git IRC channel or on this mailing list
> could turn this on if they have a problem, and paste it into some
> tool they could show to others to see exactly what they're doing /
> where it went wrong.
And they can use GIT_TRACE now. If GIT_TRACE does not give enough info
(e.g. too few trace points), add them. This new proposal is more about
automation. With GIT_TRACE, which is more human friendly, I could skim
over the output and remove sensitive info before I send it out for
help. Machine-friendly format (even json) tends to be a lot more
complex and harder to read/filter this way.
--
Duy
next prev parent reply other threads:[~2018-06-09 7:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 14:53 [RFC PATCH v1] telemetry design overview (part 1) git
2018-06-07 14:53 ` [RFC PATCH v1] telemetry: design documenation git
2018-06-08 11:06 ` Ævar Arnfjörð Bjarmason
2018-06-07 21:10 ` [RFC PATCH v1] telemetry design overview (part 1) Johannes Sixt
2018-06-08 9:07 ` Jeff King
2018-06-08 16:00 ` Thomas Braun
2018-06-08 22:01 ` Johannes Sixt
2018-06-08 22:20 ` Ævar Arnfjörð Bjarmason
2018-06-09 5:03 ` Duy Nguyen
2018-06-09 6:31 ` Ævar Arnfjörð Bjarmason
2018-06-09 6:56 ` Jeff King
2018-06-09 20:05 ` Johannes Schindelin
2018-06-11 5:56 ` Jeff King
2018-06-09 7:31 ` Duy Nguyen [this message]
2018-06-09 6:51 ` Jeff King
2018-06-09 7:04 ` Johannes Sixt
2018-06-09 7:31 ` Jeff King
2018-06-12 16:04 ` Junio C Hamano
2018-06-09 6:56 ` Johannes Sixt
2018-06-09 20:43 ` Johannes Schindelin
2018-06-09 22:44 ` Johannes Sixt
2018-06-11 6:08 ` Jeff King
2018-06-10 0:00 ` brian m. carlson
2018-06-11 6:14 ` Jeff King
2018-06-11 8:30 ` Jeff King
2018-06-08 9:40 ` Ævar Arnfjörð Bjarmason
2018-06-08 15:46 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8DrtAdwH0dOjptJ0JDQ_gOeiTVbRknui4gM5P85Y5JZow@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).