From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Thomas Braun" <thomas.braun@virtuell-zuhause.de>,
"Jeff King" <peff@peff.net>,
git@jeffhostetler.com, git@vger.kernel.org, gitster@pobox.com,
"Jeff Hostetler" <jeffhost@microsoft.com>
Subject: Re: [RFC PATCH v1] telemetry design overview (part 1)
Date: Sat, 9 Jun 2018 22:43:37 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1806092241180.77@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <900a34bb-4d8b-4a22-a0f5-1d2f6df84945@kdbg.org>
[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]
Hi Hannes,
On Sat, 9 Jun 2018, Johannes Sixt wrote:
> Am 09.06.2018 um 00:20 schrieb Ævar Arnfjörð Bjarmason:
> >
> > On Fri, Jun 08 2018, Johannes Sixt wrote:
> >
> > > Am 08.06.2018 um 18:00 schrieb Thomas Braun:
> > > > I for my part would much rather prefer that to be a compile time
> > > > option so that I don't need to check on every git update on windows
> > > > if this is now enabled or not.
> > >
> > > This exactly my concern, too! A compile-time option may make it a good
> > > deal less worrisome.
> >
> > Can you elaborate on how someone who can maintain inject malicious code
> > into your git package + config would be thwarted by this being some
> > compile-time option, wouldn't they just compile it in?
>
> Of course they can. But would we, the Git community do that?
>
> From the design document:
>
> > The goal of the telemetry feature is to be able to gather usage data
> > across a group of production users to identify real-world performance
> > problems in production. Additionally, it might help identify common
> > user errors and guide future user training.
>
> The goal to gather usage data may be valid for a small subset of Git
> installations. But it is wrong to put this into the software itself, in
> particular when the implementations includes scary things like loading
> unspecified dynamic libraries:
>
> > If the config setting "telemetry.plugin" contains the pathname to a
> > shared library, the library will be dynamically loaded during start up
> > and events will be sent to it using the plugin API.
>
> When you want usage data, ask your users for feedback. Look over their
> shoulders. But do not ask the software itself to gather usage data. It will be
> abused.
>
> Do not offer open source software that has a "call-home" method built-in.
>
> If you want to peek into the workplaces of YOUR users, then monkey-patch
> survaillance into YOUR version of Git. But please do not burden the rest of
> us.
We already offer hooks. You can do anything with those hooks. Even, if you
do not pay close attention, to transfer all your bitcoin to a specific
account.
I agree with Peff: this is something you as a user need to be aware of,
and need to make sure you configure your Git just like you want. As long
as this is a purely opt-in feature, it is useful and helpful.
We do need it in-house, for the many thousands of Git users we try to
support with a relatively small team of Git developers.
Ciao,
Dscho
next prev parent reply other threads:[~2018-06-09 20:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 14:53 [RFC PATCH v1] telemetry design overview (part 1) git
2018-06-07 14:53 ` [RFC PATCH v1] telemetry: design documenation git
2018-06-08 11:06 ` Ævar Arnfjörð Bjarmason
2018-06-07 21:10 ` [RFC PATCH v1] telemetry design overview (part 1) Johannes Sixt
2018-06-08 9:07 ` Jeff King
2018-06-08 16:00 ` Thomas Braun
2018-06-08 22:01 ` Johannes Sixt
2018-06-08 22:20 ` Ævar Arnfjörð Bjarmason
2018-06-09 5:03 ` Duy Nguyen
2018-06-09 6:31 ` Ævar Arnfjörð Bjarmason
2018-06-09 6:56 ` Jeff King
2018-06-09 20:05 ` Johannes Schindelin
2018-06-11 5:56 ` Jeff King
2018-06-09 7:31 ` Duy Nguyen
2018-06-09 6:51 ` Jeff King
2018-06-09 7:04 ` Johannes Sixt
2018-06-09 7:31 ` Jeff King
2018-06-12 16:04 ` Junio C Hamano
2018-06-09 6:56 ` Johannes Sixt
2018-06-09 20:43 ` Johannes Schindelin [this message]
2018-06-09 22:44 ` Johannes Sixt
2018-06-11 6:08 ` Jeff King
2018-06-10 0:00 ` brian m. carlson
2018-06-11 6:14 ` Jeff King
2018-06-11 8:30 ` Jeff King
2018-06-08 9:40 ` Ævar Arnfjörð Bjarmason
2018-06-08 15:46 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1806092241180.77@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).