From: Duy Nguyen <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
Jeff King <peff@peff.net>, Jeff Hostetler <git@jeffhostetler.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [RFC PATCH v1] telemetry design overview (part 1)
Date: Sat, 9 Jun 2018 07:03:53 +0200 [thread overview]
Message-ID: <CACsJy8BPhzs5M4peHN2HczmDxGmAuKZ0corzT66i+rJ2UQRTHQ@mail.gmail.com> (raw)
In-Reply-To: <87fu1w53af.fsf@evledraar.gmail.com>
On Sat, Jun 9, 2018 at 12:22 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Fri, Jun 08 2018, Johannes Sixt wrote:
>
> > Am 08.06.2018 um 18:00 schrieb Thomas Braun:
> >> I for my part would much rather prefer that to be a compile time
> >> option so that I don't need to check on every git update on windows
> >> if this is now enabled or not.
> >
> > This exactly my concern, too! A compile-time option may make it a good
> > deal less worrisome.
>
> Can you elaborate on how someone who can maintain inject malicious code
> into your git package + config would be thwarted by this being some
> compile-time option, wouldn't they just compile it in?
Look at this from a different angle. This is driven by the needs to
collect telemetry in _controlled_ environment (mostly server side, I
guess) and it should be no problem to make custom builds there for
you. Not making it a compile-time option could force [1] linux distro
to carry this function to everybody even if they don't use it (and
it's kinda dangerous to misuse if you don't anonymize the data
properly). I also prefer this a compile time option.
[1] Of course many distros can choose to patch it out. But it's the
same argument as bringing this option in in the first place: you guys
already have that code in private and now want to put it in stock git
to reduce maintenance cost, why add extra cost on linux distro
maintenance?
--
Duy
next prev parent reply other threads:[~2018-06-09 5:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 14:53 [RFC PATCH v1] telemetry design overview (part 1) git
2018-06-07 14:53 ` [RFC PATCH v1] telemetry: design documenation git
2018-06-08 11:06 ` Ævar Arnfjörð Bjarmason
2018-06-07 21:10 ` [RFC PATCH v1] telemetry design overview (part 1) Johannes Sixt
2018-06-08 9:07 ` Jeff King
2018-06-08 16:00 ` Thomas Braun
2018-06-08 22:01 ` Johannes Sixt
2018-06-08 22:20 ` Ævar Arnfjörð Bjarmason
2018-06-09 5:03 ` Duy Nguyen [this message]
2018-06-09 6:31 ` Ævar Arnfjörð Bjarmason
2018-06-09 6:56 ` Jeff King
2018-06-09 20:05 ` Johannes Schindelin
2018-06-11 5:56 ` Jeff King
2018-06-09 7:31 ` Duy Nguyen
2018-06-09 6:51 ` Jeff King
2018-06-09 7:04 ` Johannes Sixt
2018-06-09 7:31 ` Jeff King
2018-06-12 16:04 ` Junio C Hamano
2018-06-09 6:56 ` Johannes Sixt
2018-06-09 20:43 ` Johannes Schindelin
2018-06-09 22:44 ` Johannes Sixt
2018-06-11 6:08 ` Jeff King
2018-06-10 0:00 ` brian m. carlson
2018-06-11 6:14 ` Jeff King
2018-06-11 8:30 ` Jeff King
2018-06-08 9:40 ` Ævar Arnfjörð Bjarmason
2018-06-08 15:46 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BPhzs5M4peHN2HczmDxGmAuKZ0corzT66i+rJ2UQRTHQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).