From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>,
<git@vger.kernel.org>
Subject: Re: [RFC] imap-send: escape backslash in password
Date: Fri, 04 Aug 2017 21:46:49 +0200 [thread overview]
Message-ID: <87bmnvktee.fsf@linux-m68k.org> (raw)
In-Reply-To: <xmqqbmnvtain.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Fri, 04 Aug 2017 12:09:52 -0700")
On Aug 04 2017, Junio C Hamano <gitster@pobox.com> wrote:
> Is the quoting rules documented somewhere? If so, please also give
> a reference to it here. RFC3501 "6.2.3 LOGIN Command" does not say
> much (other parts of the RFC may specify the rules that apply to
> arguments in general, but I didn't look for them). Without such
> reference, it is hard to judge if this change is sufficient or even
> correct (in an extreme case, the IMAP server you are talking with
> that prompted you to make this change might be in violation).
>
> For example, FRC3501 "9. Formal Syntax" says that both "password"
> and "userid" are "astring"; it looks strange that the code with this
> patch only touches cred.password while sending cred.username as-is.
astring = ... / string
string = quoted / ...
quoted = DQUOTE *QUOTED-CHAR DQUOTE
QUOTED-CHAR = <any TEXT-CHAR except quoted-specials> /
"\" quoted-specials
quoted-specials = DQUOTE / "\"
Thus the quoting applies to any element that is a string (and a double
quote needs to be quoted as well).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2017-08-04 19:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 16:16 [RFC] imap-send: escape backslash in password Nicolas Morey-Chaisemartin
2017-08-04 19:09 ` Junio C Hamano
2017-08-04 19:32 ` Nicolas Morey-Chaisemartin
2017-08-04 19:46 ` Andreas Schwab [this message]
2017-08-04 20:22 ` Jeff King
2017-08-04 21:18 ` Junio C Hamano
2017-08-04 21:22 ` Jeff King
2017-08-06 19:12 ` Nicolas Morey-Chaisemartin
2017-08-07 20:58 ` Jeff King
2017-08-07 1:34 ` Junio C Hamano
2017-08-08 7:25 ` Jeff King
2017-08-08 16:54 ` Junio C Hamano
2017-08-09 12:04 ` Jeff King
2017-08-04 20:06 ` brian m. carlson
2017-08-04 20:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmnvktee.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nicolas@morey-chaisemartin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).