From: Jeff King <peff@peff.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>,
git@vger.kernel.org
Subject: Re: [RFC] imap-send: escape backslash in password
Date: Fri, 4 Aug 2017 16:22:55 -0400 [thread overview]
Message-ID: <20170804202255.3oia7ivsoa6vu4me@sigill.intra.peff.net> (raw)
In-Reply-To: <87bmnvktee.fsf@linux-m68k.org>
On Fri, Aug 04, 2017 at 09:46:49PM +0200, Andreas Schwab wrote:
> > For example, FRC3501 "9. Formal Syntax" says that both "password"
> > and "userid" are "astring"; it looks strange that the code with this
> > patch only touches cred.password while sending cred.username as-is.
>
> astring = ... / string
> string = quoted / ...
> quoted = DQUOTE *QUOTED-CHAR DQUOTE
> QUOTED-CHAR = <any TEXT-CHAR except quoted-specials> /
> "\" quoted-specials
> quoted-specials = DQUOTE / "\"
>
> Thus the quoting applies to any element that is a string (and a double
> quote needs to be quoted as well).
It's been a long time since I've done anything with IMAP, but I think
another alternative would be to send it as a "literal", like:
{6}
foobar
That's relatively easy to format correctly using the current printf
specifiers that imap_exec() takes. Though as I said elsewhere in the
thread, perhaps imap_exec() should provide a different interface.
I also think it might be reasonable to scrap all of this ad-hoc imap
code in favor of curl, which already gets these cases right. We already
have a curl-backed implementation. I think we just left the old code out
of conservatism. But it seems somewhat buggy and unmaintained, and I
wonder if we aren't better off to simply encourage people to install
curl.
-Peff
next prev parent reply other threads:[~2017-08-04 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 16:16 [RFC] imap-send: escape backslash in password Nicolas Morey-Chaisemartin
2017-08-04 19:09 ` Junio C Hamano
2017-08-04 19:32 ` Nicolas Morey-Chaisemartin
2017-08-04 19:46 ` Andreas Schwab
2017-08-04 20:22 ` Jeff King [this message]
2017-08-04 21:18 ` Junio C Hamano
2017-08-04 21:22 ` Jeff King
2017-08-06 19:12 ` Nicolas Morey-Chaisemartin
2017-08-07 20:58 ` Jeff King
2017-08-07 1:34 ` Junio C Hamano
2017-08-08 7:25 ` Jeff King
2017-08-08 16:54 ` Junio C Hamano
2017-08-09 12:04 ` Jeff King
2017-08-04 20:06 ` brian m. carlson
2017-08-04 20:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804202255.3oia7ivsoa6vu4me@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nicolas@morey-chaisemartin.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).