From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>,
git@vger.kernel.org
Subject: Re: [RFC] imap-send: escape backslash in password
Date: Wed, 9 Aug 2017 08:04:32 -0400 [thread overview]
Message-ID: <20170809120432.am77utnrnkh6mpgt@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqk22ec84i.fsf@gitster.mtv.corp.google.com>
On Tue, Aug 08, 2017 at 09:54:53AM -0700, Junio C Hamano wrote:
> > For comparison, nothing older than curl 7.19.4 will work for building
> > Git since v2.12.0, as we added some unconditional uses of CURLPROTO_*
> > there. Nobody seems to have noticed or complained. I pointed this out a
> > few months ago[1] and suggested we clean up some of the more antiquated
> > #if blocks in http.c that don't even build. There was some complaint
> > that we should keep even these ancient versions working, but the
> > compile error is still in "master".
> >
> > So it's not clear to me that anybody cares about going that far back
> > (which is mid-2009), but I'd guess that 2013 might cause some problems.
> >
> > [1] https://public-inbox.org/git/20170404025438.bgxz5sfmrawqswcj@sigill.intra.peff.net/
> > if you're curious (you were offline for a while at that time, I
> > think).
>
> Thanks for digging. It would not help the issue on this thread at
> all. While I agree with your conclusion in the quoted thread:
>
> I think it might be nice to declare a "too old" version, though,
> just so we can stop adding _new_ ifdefs. Maybe 7.11.1 is that
> version now, and in another few years we can bump to 7.16.0. :)
>
> it appears that we silently declared it to 7.19.4 and found out that
> nobody complained, without us having to wait for a few years?
Yeah, I think the 7.19.4 breakage was discussed after I wrote that (and
after investigating, I think the 7.16.0 cutoff is probably pretty
reasonable even without that). I do think it's worth addressing. I just
sent a series:
https://public-inbox.org/git/20170809120024.7phdjzjv54uv5dpz@sigill.intra.peff.net/
-Peff
next prev parent reply other threads:[~2017-08-09 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 16:16 [RFC] imap-send: escape backslash in password Nicolas Morey-Chaisemartin
2017-08-04 19:09 ` Junio C Hamano
2017-08-04 19:32 ` Nicolas Morey-Chaisemartin
2017-08-04 19:46 ` Andreas Schwab
2017-08-04 20:22 ` Jeff King
2017-08-04 21:18 ` Junio C Hamano
2017-08-04 21:22 ` Jeff King
2017-08-06 19:12 ` Nicolas Morey-Chaisemartin
2017-08-07 20:58 ` Jeff King
2017-08-07 1:34 ` Junio C Hamano
2017-08-08 7:25 ` Jeff King
2017-08-08 16:54 ` Junio C Hamano
2017-08-09 12:04 ` Jeff King [this message]
2017-08-04 20:06 ` brian m. carlson
2017-08-04 20:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809120432.am77utnrnkh6mpgt@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nicolas@morey-chaisemartin.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).