From: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
To: <git@vger.kernel.org>
Subject: [RFC] imap-send: escape backslash in password
Date: Fri, 4 Aug 2017 18:16:53 +0200 [thread overview]
Message-ID: <58b783d6-c024-4491-2f88-edfb9c43c55c@morey-chaisemartin.com> (raw)
Password containing backslashes need to have them doubled to have them properly interpreted by the imap server.
A password terminating with a blackslash used to trigger this error:
IMAP command 'LOGIN <user> <pass>' returned response (BAD) - Missing '"'
Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
imap-send.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c
index b2d0b849b..7fde6ec96 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -926,6 +926,32 @@ static int auth_cram_md5(struct imap_store *ctx, struct imap_cmd *cmd, const cha
return 0;
}
+static char* imap_escape_password(const char *passwd)
+{
+ const unsigned passwd_len = strlen(passwd);
+ char *escaped = xmalloc(2 * passwd_len + 1);
+ const char *passwd_cur = passwd;
+ char *escaped_cur = escaped;
+
+ do {
+ char *next = strchr(passwd_cur, '\\');
+
+ if (!next) {
+ strcpy(escaped_cur, passwd_cur);
+ } else {
+ int len = next - passwd_cur + 1;
+
+ memcpy(escaped_cur, passwd_cur, len);
+ escaped_cur += len;
+ next++;
+ *(escaped_cur++) = '\\';
+ }
+ passwd_cur = next;
+ } while(passwd_cur);
+
+ return escaped;
+}
+
static struct imap_store *imap_open_store(struct imap_server_conf *srvc, char *folder)
{
struct credential cred = CREDENTIAL_INIT;
@@ -1090,7 +1116,7 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc, char *f
if (!srvc->user)
srvc->user = xstrdup(cred.username);
if (!srvc->pass)
- srvc->pass = xstrdup(cred.password);
+ srvc->pass = imap_escape_password(cred.password);
}
if (srvc->auth_method) {
next reply other threads:[~2017-08-04 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 16:16 Nicolas Morey-Chaisemartin [this message]
2017-08-04 19:09 ` [RFC] imap-send: escape backslash in password Junio C Hamano
2017-08-04 19:32 ` Nicolas Morey-Chaisemartin
2017-08-04 19:46 ` Andreas Schwab
2017-08-04 20:22 ` Jeff King
2017-08-04 21:18 ` Junio C Hamano
2017-08-04 21:22 ` Jeff King
2017-08-06 19:12 ` Nicolas Morey-Chaisemartin
2017-08-07 20:58 ` Jeff King
2017-08-07 1:34 ` Junio C Hamano
2017-08-08 7:25 ` Jeff King
2017-08-08 16:54 ` Junio C Hamano
2017-08-09 12:04 ` Jeff King
2017-08-04 20:06 ` brian m. carlson
2017-08-04 20:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b783d6-c024-4491-2f88-edfb9c43c55c@morey-chaisemartin.com \
--to=nicolas@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).