From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Karsten Blees" <karsten.blees@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>
Subject: Re: [PATCH] t/README: test_must_fail is for testing Git
Date: Tue, 4 Jun 2013 22:12:06 +0100 [thread overview]
Message-ID: <82E212D3F25A4ABA923D1D81684F6578@PhilipOakley> (raw)
In-Reply-To: 7v1u8h7gac.fsf@alter.siamese.dyndns.org
From: "Junio C Hamano" <gitster@pobox.com>
Sent: Tuesday, June 04, 2013 9:49 PM
> "Philip Oakley" <philipoakley@iee.org> writes:
>
>> From: "Junio C Hamano" <gitster@pobox.com>
>> Sent: Tuesday, June 04, 2013 5:50 PM
>>> When a test wants to make sure there is no <string> in an output
>>> file, we should just say "! grep string output";
>>
>> Small nit: It took me two readings of the commit message to correctly
>> parse this break point. The flowing together of the two parts with
>> the
>> semicolon fooled me. Separate them?
>>
>>> "test_must_fail"
>>> is there only to test Git command and catch unusual deaths we know
>>> about (e.g. segv) as an error, not as an expected failure.
>
> Thanks. Does this read better?
Yes. Thanks.
>
> t/README: test_must_fail is for testing Git
>
> When a test wants to make sure there is no <string> in an output
> file, we should just say "! grep string output".
>
> "test_must_fail" is there only to test Git command and catch
> unusual
> deaths we know about (e.g. segv) as an error, not as an expected
> failure. "test_must_fail grep string output" is unnecessary, as
> we are not making sure the system binaries do not dump core or
> anything like that.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> --
Philip
prev parent reply other threads:[~2013-06-04 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:54 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken? Misty De Meo
2013-05-28 21:35 ` Øystein Walle
2013-05-28 21:59 ` Junio C Hamano
2013-05-29 3:41 ` Duy Nguyen
2013-05-29 4:19 ` Duy Nguyen
2013-05-29 7:43 ` David Aguilar
2013-05-29 16:19 ` Karsten Blees
2013-05-29 18:49 ` Øystein Walle
2013-05-29 20:32 ` [PATCH] dir.c: fix ignore processing within not-ignored directories Karsten Blees
2013-06-01 10:44 ` Duy Nguyen
2013-06-02 19:25 ` Junio C Hamano
2013-06-04 16:10 ` Karsten Blees
2013-06-04 16:50 ` [PATCH] t/README: test_must_fail is for testing Git Junio C Hamano
2013-06-04 20:16 ` Philip Oakley
2013-06-04 20:49 ` Junio C Hamano
2013-06-04 21:12 ` Philip Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82E212D3F25A4ABA923D1D81684F6578@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).