From: "Øystein Walle" <oystwa@gmail.com>
To: git@vger.kernel.org
Subject: Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?
Date: Wed, 29 May 2013 18:49:58 +0000 (UTC) [thread overview]
Message-ID: <loom.20130529T204310-306@post.gmane.org> (raw)
In-Reply-To: 51A62A96.6040009@gmail.com
Karsten Blees <karsten.blees <at> gmail.com> writes:
> <at> Øystein: in the meantime, could you check if this fixes the problem
for you?
>
> --- 8< ---
> diff --git a/dir.c b/dir.c
> index a5926fb..13858fe 100644
> --- a/dir.c
> +++ b/dir.c
> <at> <at> -821,6 +821,9 <at> <at> static void prep_exclude(struct
dir_struct *dir, const char *base, int baselen)
> dir->basebuf, stk->baselen - 1,
> dir->basebuf + current, &dt);
> dir->basebuf[stk->baselen - 1] = '/';
> + if (dir->exclude &&
> + dir->exclude->flags & EXC_FLAG_NEGATIVE)
> + dir->exclude = NULL;
> if (dir->exclude) {
> dir->basebuf[stk->baselen] = 0;
> dir->exclude_stack = stk;
Hi, Karsten
I applied your fix on v1.8.3 on both systems I mentioned earlier and
from my tests the issue I reported is fixed.
Thank you very much! :)
Regards
Øsse
next prev parent reply other threads:[~2013-05-29 18:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:54 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken? Misty De Meo
2013-05-28 21:35 ` Øystein Walle
2013-05-28 21:59 ` Junio C Hamano
2013-05-29 3:41 ` Duy Nguyen
2013-05-29 4:19 ` Duy Nguyen
2013-05-29 7:43 ` David Aguilar
2013-05-29 16:19 ` Karsten Blees
2013-05-29 18:49 ` Øystein Walle [this message]
2013-05-29 20:32 ` [PATCH] dir.c: fix ignore processing within not-ignored directories Karsten Blees
2013-06-01 10:44 ` Duy Nguyen
2013-06-02 19:25 ` Junio C Hamano
2013-06-04 16:10 ` Karsten Blees
2013-06-04 16:50 ` [PATCH] t/README: test_must_fail is for testing Git Junio C Hamano
2013-06-04 20:16 ` Philip Oakley
2013-06-04 20:49 ` Junio C Hamano
2013-06-04 21:12 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20130529T204310-306@post.gmane.org \
--to=oystwa@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).