From: Junio C Hamano <gitster@pobox.com>
To: "Karsten Blees" <karsten.blees@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Øystein Walle" <oystwa@gmail.com>
Subject: Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?
Date: Tue, 28 May 2013 14:59:57 -0700 [thread overview]
Message-ID: <7vhahmydcy.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20130528T232459-307@post.gmane.org> ("Øystein Walle"'s message of "Tue, 28 May 2013 21:35:01 +0000 (UTC)")
Øystein Walle <oystwa@gmail.com> writes:
> Misty De Meo <misty <at> brew.sh> writes:
>
>>
>> Hi,
>>
>> Gitignore parsing no longer seems to work properly in git 1.8.3.
>>
>> One of my repositories has the following gitignore:
>>
>> /*
>> !/.gitignore
>> !/Library/
>> !/CONTRIBUTING.md
>> !/README.md
>> !/SUPPORTERS.md
>> !/bin
>> /bin/*
>> !/bin/brew
>> !/share/man/man1/brew.1
>> .DS_Store
>> /Library/LinkedKegs
>> /Library/PinnedKegs
>> /Library/Taps
>> /Library/Formula/.gitignore
>>
>> In 1.8.2.3 and earlier, this works as expected. However, in 1.8.3 I'm
>> seeing every file in /bin/ being marked as an untracked file.
>>
>> I asked about this in #git, and was told that the culprit was the
>> regex support; apparently recompiling without regex support fixes the
>> specific gitignore issue. However, this doesn't seem to have been
>> reported anywhere on the mailing list that I can see. I was also told
>> that the issue is OS X-specific, and doesn't happen on other
>> platforms.
>>
>> Thanks,
>> Misty De Meo
>>
>
> I see a similar problem using e.g. the following .gitignore to exclude
> everything except C source files and header files:
>
> *
> !*/
> !*.c
> !*.h
>
> In Git 1.8.3 'git status' will show other files as untracked while in
> Git 1.8.2.3 I don't have that problem. I bisected to find that the
> offending commit is v1.8.2.1-402-g95c6f27.
>
> I am not on OSX, however, but on Linux (Ubuntu 12.04 and RHEL 5.8) so
> this may be a separate issue. I've also gotten the impression that this
> is intentional. In any case I cannot create a .gitignore that achieves
> the same for both older and newer versions of Git.
Thanks; 95c6f27 is from Karsten and I think Duy is the most clueful
one in this area in the discussion that had this change; I am
forwarding this message to them.
Cf. http://thread.gmane.org/gmane.comp.version-control.git/218440/focus=221289
next prev parent reply other threads:[~2013-05-28 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:54 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken? Misty De Meo
2013-05-28 21:35 ` Øystein Walle
2013-05-28 21:59 ` Junio C Hamano [this message]
2013-05-29 3:41 ` Duy Nguyen
2013-05-29 4:19 ` Duy Nguyen
2013-05-29 7:43 ` David Aguilar
2013-05-29 16:19 ` Karsten Blees
2013-05-29 18:49 ` Øystein Walle
2013-05-29 20:32 ` [PATCH] dir.c: fix ignore processing within not-ignored directories Karsten Blees
2013-06-01 10:44 ` Duy Nguyen
2013-06-02 19:25 ` Junio C Hamano
2013-06-04 16:10 ` Karsten Blees
2013-06-04 16:50 ` [PATCH] t/README: test_must_fail is for testing Git Junio C Hamano
2013-06-04 20:16 ` Philip Oakley
2013-06-04 20:49 ` Junio C Hamano
2013-06-04 21:12 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhahmydcy.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=oystwa@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).