From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Philip Oakley" Subject: Re: [PATCH] t/README: test_must_fail is for testing Git Date: Tue, 4 Jun 2013 22:12:06 +0100 Organization: OPDS Message-ID: <82E212D3F25A4ABA923D1D81684F6578@PhilipOakley> References: <51A62A96.6040009@gmail.com> <51A665E4.9080307@gmail.com><7vk3mcnwlj.fsf@alter.siamese.dyndns.org><7vppw195x7.fsf_-_@alter.siamese.dyndns.org> <7v1u8h7gac.fsf@alter.siamese.dyndns.org> Reply-To: "Philip Oakley" Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Cc: "Git Mailing List" , "Karsten Blees" , "Duy Nguyen" To: "Junio C Hamano" X-From: git-owner@vger.kernel.org Tue Jun 04 23:12:19 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UjyWg-0002bj-AF for gcvg-git-2@plane.gmane.org; Tue, 04 Jun 2013 23:12:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404Ab3FDVMI (ORCPT ); Tue, 4 Jun 2013 17:12:08 -0400 Received: from out1.ip07ir2.opaltelecom.net ([62.24.128.243]:22923 "EHLO out1.ip07ir2.opaltelecom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188Ab3FDVMH (ORCPT ); Tue, 4 Jun 2013 17:12:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtYNAIZXrlFOl3th/2dsb2JhbABUBoMJiSu2JQQBAwF8F3SCHgUBAQQBCAEBLh4BASELAgMFAgEDFQELJRQBBBoGBxcGEwgCAQIDAYd2Cr1ujX48aoMBYQOIaIYFkm2HJYMQOw X-IronPort-AV: E=Sophos;i="4.87,802,1363132800"; d="scan'208";a="74331432" Received: from host-78-151-123-97.as13285.net (HELO PhilipOakley) ([78.151.123.97]) by out1.ip07ir2.opaltelecom.net with SMTP; 04 Jun 2013 22:12:05 +0100 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: From: "Junio C Hamano" Sent: Tuesday, June 04, 2013 9:49 PM > "Philip Oakley" writes: > >> From: "Junio C Hamano" >> Sent: Tuesday, June 04, 2013 5:50 PM >>> When a test wants to make sure there is no in an output >>> file, we should just say "! grep string output"; >> >> Small nit: It took me two readings of the commit message to correctly >> parse this break point. The flowing together of the two parts with >> the >> semicolon fooled me. Separate them? >> >>> "test_must_fail" >>> is there only to test Git command and catch unusual deaths we know >>> about (e.g. segv) as an error, not as an expected failure. > > Thanks. Does this read better? Yes. Thanks. > > t/README: test_must_fail is for testing Git > > When a test wants to make sure there is no in an output > file, we should just say "! grep string output". > > "test_must_fail" is there only to test Git command and catch > unusual > deaths we know about (e.g. segv) as an error, not as an expected > failure. "test_must_fail grep string output" is unnecessary, as > we are not making sure the system binaries do not dump core or > anything like that. > > Signed-off-by: Junio C Hamano > -- Philip