From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
git@vger.kernel.org, "Chris Hiestand" <chrishiestand@gmail.com>,
"Marc Branchaud" <mbranchaud@xiplink.com>,
"Michiel Holtkamp" <git@elfstone.nl>,
"Stefan Näwe" <stefan.naewe@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>
Subject: Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Date: Mon, 15 Jul 2013 06:38:22 -0700 [thread overview]
Message-ID: <7vip0cdju9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqoba4gr9h.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 15 Jul 2013 10:29:46 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> (3)
>> # An example hook ...
>> #
>> # Warning: this script is no longer actively maintained. Consider
>> # switching to ...
>>
>> I prefer (2), which makes it clear to the reader that it is dangerous
>> to keep using the script (since no one is actively chasing down bugs)
>> while also making it clear why a potentially buggy script with a good
>> natural successor is still in contrib for now. What do you think?
>
> I don't think it is dangerous to keep using the old script. If you look
> at its history, it's pretty stable these day. I think it has known bugs
> in new revision detections that are fixed by git-multimail, but nothing
> really blocking IMHO.
>
> There are two good reasons to use it: 1) you already use it, and you're
> too lazy to change (e.g. because it's packaged by Debian and is already
> there on your server), and 2) you don't have Python on your server.
Well said.
> I think the notice still deserve the "***NOTICE***" or whatever makes it
> visible enough to distinguish it from the traditional licence &
> non-warranty header, but I don't think we should kill the old script too
> early.
True. I personally felt that Jonathan's (1) read the most natural
(i.e. showing no strong preference, just let the users decide).
next prev parent reply other threads:[~2013-07-15 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 8:09 [PATCH v4 0/2] git-multimail: a replacement for post-receive-email Michael Haggerty
2013-07-14 8:09 ` [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail Michael Haggerty
2013-07-15 6:02 ` Jonathan Nieder
2013-07-15 8:17 ` Michael Haggerty
2013-07-15 8:29 ` Matthieu Moy
2013-07-15 13:38 ` Junio C Hamano [this message]
2013-07-23 4:20 ` Junio C Hamano
[not found] ` <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>
2013-07-15 5:47 ` [PATCH v4 1/2] git-multimail: an improved replacement for post-receive-email Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vip0cdju9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=chrishiestand@gmail.com \
--cc=git@elfstone.nl \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
--cc=mbranchaud@xiplink.com \
--cc=mhagger@alum.mit.edu \
--cc=stefan.naewe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).