git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "Chris Hiestand" <chrishiestand@gmail.com>,
	"Marc Branchaud" <mbranchaud@xiplink.com>,
	"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
	"Michiel Holtkamp" <git@elfstone.nl>,
	"Stefan Näwe" <stefan.naewe@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Ramkumar Ramachandra" <artagnon@gmail.com>,
	"John Keeping" <john@keeping.me.uk>
Subject: Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Date: Sun, 14 Jul 2013 23:02:45 -0700	[thread overview]
Message-ID: <20130715060245.GD2962@elie.Belkin> (raw)
In-Reply-To: <1373789343-3189-3-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

> Add a notice to the top of post-receive-email explaining that the
> script is no longer under active development and pointing the user to
> git-multimail.

I think the spirit of this patch is sane.  Some thoughts on wording:

[...]
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -2,10 +2,19 @@
>  #
>  # Copyright (c) 2007 Andy Parkins
>  #
> -# An example hook script to mail out commit update information.  This hook
> -# sends emails listing new revisions to the repository introduced by the
> -# change being reported.  The rule is that (for branch updates) each commit
> -# will appear on one email and one email only.
> +# An example hook script to mail out commit update information.
> +#
> +# ***NOTICE***: This script is no longer under active development.  It
> +# has been superseded by git-multimail, which is more capable and
> +# configurable and is largely backwards-compatible with this script;
> +# please see "contrib/hooks/multimail/".  For instructions on how to
> +# migrate from post-receive-email to git-multimail, please see
> +# "README.migrate-from-post-receive-email" in that directory.

I think I'd say something like

(1)
	# An example hook script to mail out commit update information.
	#
	# This script is kept for compatibility, but it is no longer actively
	# maintained.  Consider switching to git-multimail, which is more
	# configurable and largely compatible with this script.  See
	# contrib/hooks/multimail/README.migrate-from-post-receive.
	#
	# This hook sends emails listing new revisions ...

or, if I wanted to emphasize the warning,

(2)
	# An example hook ...
	#
	# Warning: this script is kept for compatibility, but it is no longer
	# actively maintained.  Consider switching to ...

or, if I wanted to avoid seeming to promise that the script will be
around in the future,

(3)
	# An example hook ...
	#
	# Warning: this script is no longer actively maintained.  Consider
	# switching to ...

I prefer (2), which makes it clear to the reader that it is dangerous
to keep using the script (since no one is actively chasing down bugs)
while also making it clear why a potentially buggy script with a good
natural successor is still in contrib for now.  What do you think?

Thanks,
Jonathan

  reply	other threads:[~2013-07-15  6:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14  8:09 [PATCH v4 0/2] git-multimail: a replacement for post-receive-email Michael Haggerty
2013-07-14  8:09 ` [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail Michael Haggerty
2013-07-15  6:02   ` Jonathan Nieder [this message]
2013-07-15  8:17     ` Michael Haggerty
2013-07-15  8:29     ` Matthieu Moy
2013-07-15 13:38       ` Junio C Hamano
2013-07-23  4:20         ` Junio C Hamano
     [not found] ` <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>
2013-07-15  5:47   ` [PATCH v4 1/2] git-multimail: an improved replacement for post-receive-email Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130715060245.GD2962@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=artagnon@gmail.com \
    --cc=avarab@gmail.com \
    --cc=chrishiestand@gmail.com \
    --cc=git@elfstone.nl \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    --cc=mbranchaud@xiplink.com \
    --cc=mhagger@alum.mit.edu \
    --cc=stefan.naewe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).