From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Chris Hiestand" <chrishiestand@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Marc Branchaud" <mbranchaud@xiplink.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
"Michiel Holtkamp" <git@elfstone.nl>,
"Stefan Näwe" <stefan.naewe@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v4 0/2] git-multimail: a replacement for post-receive-email
Date: Sun, 14 Jul 2013 10:09:01 +0200 [thread overview]
Message-ID: <1373789343-3189-1-git-send-email-mhagger@alum.mit.edu> (raw)
This is the fourth iteration submission of git-multimail to Git. The
earlier submissions have all gotten a lot of good feedback, which has
mostly been implemented. This submission differs from v3 in the
following ways:
* Renames the directory within the Git project from
contrib/hooks/git-multimail/ to contrib/hooks/multimail/. The
"git-" seems redundant within the Git project [1]. I have no strong
feelings either way.
* Includes the latest version of the upstream project. Highlights:
* A change in how git-multimail is configured via Python. I wasn't
happy with the old method; concerns were not separated well
enough. I wanted to get this right before more people start
writing against the internal API. The new version uses mixin
classes, which is a technique that can easily be overdone. But in
this case I was happy with the way that it permitted different
aspects of the configuration to be disentangled quite well. (This
doesn't change how the script is configured externally via "git
config"; that has been stable for quite some time already.)
* Fixes a scalability issue for repos with lots of refs that was
pointed out by Ævar Bjarmason.
* Allows an arbitrary program to be substituted in place of
/usr/sbin/sendmail when using the SendMailer.
* Improvements suggested by Ramkumar Ramachandra's code review
(thanks!).
* Various documentation improvements.
* Adds a new file, README.Git, which explains the relationship between
the Git and git-multimail projects, and documents the version of the
upstream project that corresponds to the code being submitted to the
Git project.
* Adds a notice to contrib/hooks/multimail/post-receive deprecating
that script and pointing users to git-multimail.
The upstream project also now includes better tests. Though I am not
including the tests in the code submitted to the Git project,
obviously the code benefits from them.
[1] I also got the feeling that Junio prefers the new directory name,
though there is a good chance that I read more into one of his
emails than he intended.
Michael Haggerty (2):
git-multimail: an improved replacement for post-receive-email
post-receive-email: deprecate script in favor of git-multimail
contrib/hooks/multimail/README | 486 ++++
contrib/hooks/multimail/README.Git | 15 +
.../README.migrate-from-post-receive-email | 146 ++
contrib/hooks/multimail/git_multimail.py | 2394 ++++++++++++++++++++
contrib/hooks/multimail/migrate-mailhook-config | 270 +++
contrib/hooks/multimail/post-receive | 90 +
contrib/hooks/post-receive-email | 17 +-
7 files changed, 3414 insertions(+), 4 deletions(-)
create mode 100644 contrib/hooks/multimail/README
create mode 100644 contrib/hooks/multimail/README.Git
create mode 100644 contrib/hooks/multimail/README.migrate-from-post-receive-email
create mode 100755 contrib/hooks/multimail/git_multimail.py
create mode 100755 contrib/hooks/multimail/migrate-mailhook-config
create mode 100755 contrib/hooks/multimail/post-receive
--
1.8.3.2
next reply other threads:[~2013-07-14 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 8:09 Michael Haggerty [this message]
2013-07-14 8:09 ` [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail Michael Haggerty
2013-07-15 6:02 ` Jonathan Nieder
2013-07-15 8:17 ` Michael Haggerty
2013-07-15 8:29 ` Matthieu Moy
2013-07-15 13:38 ` Junio C Hamano
2013-07-23 4:20 ` Junio C Hamano
[not found] ` <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>
2013-07-15 5:47 ` [PATCH v4 1/2] git-multimail: an improved replacement for post-receive-email Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373789343-3189-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=chrishiestand@gmail.com \
--cc=git@elfstone.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
--cc=mbranchaud@xiplink.com \
--cc=stefan.naewe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).