From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Chris Hiestand" <chrishiestand@gmail.com>,
"Marc Branchaud" <mbranchaud@xiplink.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
"Michiel Holtkamp" <git@elfstone.nl>,
"Stefan Näwe" <stefan.naewe@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ramkumar Ramachandra" <artagnon@gmail.com>,
"John Keeping" <john@keeping.me.uk>
Subject: Re: [PATCH v4 1/2] git-multimail: an improved replacement for post-receive-email
Date: Sun, 14 Jul 2013 22:47:34 -0700 [thread overview]
Message-ID: <20130715054734.GC2962@elie.Belkin> (raw)
In-Reply-To: <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>
Michael Haggerty wrote:
> Add git-multimail, a tool for generating notification emails for
> pushes to a Git repository. It is largely plug-in compatible with
> post-receive-email, and is proposed to eventually replace that script.
> The advantages of git-multimail relative to post-receive-email are
> described in README.migrate-from-post-receive-email.
Yay!
> contrib/hooks/multimail/README | 486 ++++
> contrib/hooks/multimail/README.Git | 15 +
> .../README.migrate-from-post-receive-email | 146 ++
> contrib/hooks/multimail/git_multimail.py | 2394 ++++++++++++++++++++
> contrib/hooks/multimail/migrate-mailhook-config | 270 +++
> contrib/hooks/multimail/post-receive | 90 +
> 6 files changed, 3401 insertions(+)
> create mode 100644 contrib/hooks/multimail/README
> create mode 100644 contrib/hooks/multimail/README.Git
> create mode 100644 contrib/hooks/multimail/README.migrate-from-post-receive-email
> create mode 100755 contrib/hooks/multimail/git_multimail.py
> create mode 100755 contrib/hooks/multimail/migrate-mailhook-config
> create mode 100755 contrib/hooks/multimail/post-receive
I wouldn't be surprised if it is possible to improve this in some
way or other, but where as usual "Reviewed-by" means "If I were
maintainer I would commit and push it out and as a non maintainer
I vouch for its suitability",
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
The patch integrates it into the git tree sanely and further
refinements can safely come on top. Thanks for your hard work.
prev parent reply other threads:[~2013-07-15 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 8:09 [PATCH v4 0/2] git-multimail: a replacement for post-receive-email Michael Haggerty
2013-07-14 8:09 ` [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail Michael Haggerty
2013-07-15 6:02 ` Jonathan Nieder
2013-07-15 8:17 ` Michael Haggerty
2013-07-15 8:29 ` Matthieu Moy
2013-07-15 13:38 ` Junio C Hamano
2013-07-23 4:20 ` Junio C Hamano
[not found] ` <1373789343-3189-2-git-send-email-mhagger@alum.mit.edu>
2013-07-15 5:47 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715054734.GC2962@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=chrishiestand@gmail.com \
--cc=git@elfstone.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=mbranchaud@xiplink.com \
--cc=mhagger@alum.mit.edu \
--cc=stefan.naewe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).