From: Beat Bolli <dev+git@drbeat.li>
To: Stefan Beller <sbeller@google.com>, Junio C Hamano <gitster@pobox.com>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] gitk: align the commit summary format to the documentation
Date: Fri, 26 Aug 2016 22:27:29 +0200 [thread overview]
Message-ID: <6afee090-fbe1-5d05-1f7e-6f0fc4901418@drbeat.li> (raw)
In-Reply-To: <CAGZ79kbL13b=iZiFKW8a=G+2zXRSwjYDTzu2TS47Ppohgzm0Gg@mail.gmail.com>
On 26.08.16 21:16, Stefan Beller wrote:
> On Fri, Aug 26, 2016 at 11:24 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Beat Bolli <dev+git@drbeat.li> writes:
>>
>>> In 175d38c (SubmittingPatches: document how to reference previous commits,
>>> 2016-07-28) the format for referring to older commits was specified.
>>>
>>> Make the text generated by the "Copy commit summary" command match this
>>> format.
>>
>> Hmph. I didn't know gitk already had its own command to produce a
>> short string. I actually think what it produces
>
> It was added in d835dbb91fe (gitk: Add a "Copy commit summary" command,
> 2015-07-18), it doesn't seem to be in your tree yet, so maybe wait
> with this patch
> until you pulled gitk?
This commit was part of release 2.6.0.
>>> In 175d38c ("SubmittingPatches: document how to reference previous commits",
>>> 2016-07-28) the format for referring to older commits was specified.
>>
>> is easier to read when pasted into a sentence than what the recent
>> update 175d38ca ("SubmittingPatches: document how to reference
>> previous commits", 2016-07-28) suggests to do, i.e.
>>
>>> In 175d38c (SubmittingPatches: document how to reference previous commits,
>>> 2016-07-28) the format for referring to older commits was specified.
>>
>> Heiko, Stefan, I think you two were involved in adding that new
>> paragraph. What do you think?
>
> So the subtle difference is adding '"' around the commit message subject?
>
> I agree we should fix that.
So would you prepare a amendment to your documentation commit so that
Junio can disregard my two patches?
Thanks,
Beat
next prev parent reply other threads:[~2016-08-26 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:59 [PATCH 1/2] gitk: align the commit summary format to the documentation Beat Bolli
2016-08-26 16:59 ` [PATCH 2/2] SubmittingPatches: hint at gitk's "Copy commit summary" command Beat Bolli
2016-08-26 18:27 ` Junio C Hamano
2016-08-27 3:58 ` Jacob Keller
2016-08-26 18:24 ` [PATCH 1/2] gitk: align the commit summary format to the documentation Junio C Hamano
2016-08-26 19:16 ` Stefan Beller
2016-08-26 20:27 ` Beat Bolli [this message]
2016-08-26 21:27 ` Junio C Hamano
2016-08-26 22:29 ` Stefan Beller
2016-08-27 7:21 ` Johannes Sixt
2016-08-29 18:17 ` Junio C Hamano
2016-08-29 18:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6afee090-fbe1-5d05-1f7e-6f0fc4901418@drbeat.li \
--to=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=paulus@samba.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).