From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Beat Bolli <dev+git@drbeat.li>, Heiko Voigt <hvoigt@hvoigt.net>,
Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] gitk: align the commit summary format to the documentation
Date: Sat, 27 Aug 2016 09:21:33 +0200 [thread overview]
Message-ID: <a9731f60-5c30-0bc6-f73a-f7ffb7bd4231@kdbg.org> (raw)
In-Reply-To: <xmqqoa4fgzhv.fsf@gitster.mtv.corp.google.com>
Am 26.08.2016 um 20:24 schrieb Junio C Hamano:
> Beat Bolli <dev+git@drbeat.li> writes:
>> In 175d38c ("SubmittingPatches: document how to reference previous commits",
>> 2016-07-28) the format for referring to older commits was specified.
>
> is easier to read when pasted into a sentence than what the recent
> update 175d38ca ("SubmittingPatches: document how to reference
> previous commits", 2016-07-28) suggests to do, i.e.
While it may be easier to read due to the extra mark-up, the resulting
text where such a quotation appears does not flow well, IMO. A commit
message text that references another commit reads more fluently without
the quotes around the summary line because the quoted text is not so
much a quotation that must be marked, but a parenthetical statement.
I absolutely welcome the proposed change to gitk, because I always edit
out the double-quotes.
-- Hannes
next prev parent reply other threads:[~2016-08-27 7:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:59 [PATCH 1/2] gitk: align the commit summary format to the documentation Beat Bolli
2016-08-26 16:59 ` [PATCH 2/2] SubmittingPatches: hint at gitk's "Copy commit summary" command Beat Bolli
2016-08-26 18:27 ` Junio C Hamano
2016-08-27 3:58 ` Jacob Keller
2016-08-26 18:24 ` [PATCH 1/2] gitk: align the commit summary format to the documentation Junio C Hamano
2016-08-26 19:16 ` Stefan Beller
2016-08-26 20:27 ` Beat Bolli
2016-08-26 21:27 ` Junio C Hamano
2016-08-26 22:29 ` Stefan Beller
2016-08-27 7:21 ` Johannes Sixt [this message]
2016-08-29 18:17 ` Junio C Hamano
2016-08-29 18:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9731f60-5c30-0bc6-f73a-f7ffb7bd4231@kdbg.org \
--to=j6t@kdbg.org \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=paulus@samba.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).