From: Jacob Keller <jacob.keller@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Beat Bolli <dev+git@drbeat.li>, Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] SubmittingPatches: hint at gitk's "Copy commit summary" command
Date: Fri, 26 Aug 2016 20:58:34 -0700 [thread overview]
Message-ID: <CA+P7+xopLOwWO22j8i7iWjGM-+vn0ScS9mLVNrB-qt3YCX_=yw@mail.gmail.com> (raw)
In-Reply-To: <xmqqk2f3gzcm.fsf@gitster.mtv.corp.google.com>
On Fri, Aug 26, 2016 at 11:27 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Beat Bolli <dev+git@drbeat.li> writes:
>
>> @@ -124,7 +124,8 @@ archive, summarize the relevant points of the discussion.
>> If you want to reference a previous commit in the history of a stable
>> branch use the format "abbreviated sha1 (subject, date)". So for example
>> like this: "Commit f86a374 (pack-bitmap.c: fix a memleak, 2015-03-30)
>> -noticed [...]".
>> +noticed [...]". The "Copy commit summary" command of gitk generates this
>> +format.
>
> (continuing from my 1/2 review) And if people agree that the format
> gitk already uses is better, this text should probably read more
> like:
>
> If you want to reference a previous commit in the history of a
> stable branch, use the format "abbreviated sha1 (subject, date)",
> with the subject enclosed in a pair of double-quotes, like this:
>
> Commit f86a374 ("pack-bitmap.c: fix a memleak", 2015-03-30)
> noticed that ...
>
> The "Copy commit summary" command of gitk can be used to obtain this
> format.
Tangent, but I was wondering if this would make a good built-in
format, but then I looked and realized that the built-in formats
didn't make much sense to me... I'm not sure where the actual format
gets displayed so I am wondering if we had any thoughts about adding
some --pretty=summary that we could add? I know it can be implemented
via a user defined format but thought it might be worth building it in
since it's a pretty common use case?
Thanks,
Jake
next prev parent reply other threads:[~2016-08-27 3:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:59 [PATCH 1/2] gitk: align the commit summary format to the documentation Beat Bolli
2016-08-26 16:59 ` [PATCH 2/2] SubmittingPatches: hint at gitk's "Copy commit summary" command Beat Bolli
2016-08-26 18:27 ` Junio C Hamano
2016-08-27 3:58 ` Jacob Keller [this message]
2016-08-26 18:24 ` [PATCH 1/2] gitk: align the commit summary format to the documentation Junio C Hamano
2016-08-26 19:16 ` Stefan Beller
2016-08-26 20:27 ` Beat Bolli
2016-08-26 21:27 ` Junio C Hamano
2016-08-26 22:29 ` Stefan Beller
2016-08-27 7:21 ` Johannes Sixt
2016-08-29 18:17 ` Junio C Hamano
2016-08-29 18:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+P7+xopLOwWO22j8i7iWjGM-+vn0ScS9mLVNrB-qt3YCX_=yw@mail.gmail.com' \
--to=jacob.keller@gmail.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).