From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1CDB71FD99 for ; Fri, 26 Aug 2016 20:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbcHZUku (ORCPT ); Fri, 26 Aug 2016 16:40:50 -0400 Received: from mx1.2b3w.ch ([92.42.186.250]:51272 "EHLO mx1.2b3w.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcHZUkt (ORCPT ); Fri, 26 Aug 2016 16:40:49 -0400 X-Greylist: delayed 717 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 Aug 2016 16:40:49 EDT Received: from mx1.2b3w.ch (localhost [127.0.0.1]) by mx1.2b3w.ch (Postfix) with ESMTP id 219EFC3442; Fri, 26 Aug 2016 22:28:15 +0200 (CEST) Received: from mcmini.bolli (215-243-153-5.dyn.cable.fcom.ch [5.153.243.215]) by mx1.2b3w.ch (Postfix) with ESMTPSA id E2BAFC3431; Fri, 26 Aug 2016 22:28:14 +0200 (CEST) Subject: Re: [PATCH 1/2] gitk: align the commit summary format to the documentation To: Stefan Beller , Junio C Hamano References: <1472230741-5161-1-git-send-email-dev+git@drbeat.li> Cc: Heiko Voigt , "git@vger.kernel.org" , Paul Mackerras From: Beat Bolli Message-ID: <6afee090-fbe1-5d05-1f7e-6f0fc4901418@drbeat.li> Date: Fri, 26 Aug 2016 22:27:29 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 26.08.16 21:16, Stefan Beller wrote: > On Fri, Aug 26, 2016 at 11:24 AM, Junio C Hamano wrote: >> Beat Bolli writes: >> >>> In 175d38c (SubmittingPatches: document how to reference previous commits, >>> 2016-07-28) the format for referring to older commits was specified. >>> >>> Make the text generated by the "Copy commit summary" command match this >>> format. >> >> Hmph. I didn't know gitk already had its own command to produce a >> short string. I actually think what it produces > > It was added in d835dbb91fe (gitk: Add a "Copy commit summary" command, > 2015-07-18), it doesn't seem to be in your tree yet, so maybe wait > with this patch > until you pulled gitk? This commit was part of release 2.6.0. >>> In 175d38c ("SubmittingPatches: document how to reference previous commits", >>> 2016-07-28) the format for referring to older commits was specified. >> >> is easier to read when pasted into a sentence than what the recent >> update 175d38ca ("SubmittingPatches: document how to reference >> previous commits", 2016-07-28) suggests to do, i.e. >> >>> In 175d38c (SubmittingPatches: document how to reference previous commits, >>> 2016-07-28) the format for referring to older commits was specified. >> >> Heiko, Stefan, I think you two were involved in adding that new >> paragraph. What do you think? > > So the subtle difference is adding '"' around the commit message subject? > > I agree we should fix that. So would you prepare a amendment to your documentation commit so that Junio can disregard my two patches? Thanks, Beat