From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: Shawn Pearce <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: reftable: new ref storage format
Date: Sun, 16 Jul 2017 12:10:29 +0200 [thread overview]
Message-ID: <4c2b03e6-cd29-6dec-e816-ce2c847355c4@kdbg.org> (raw)
In-Reply-To: <20170716100321.3jj4pdz7jqoa3dr4@sigill.intra.peff.net>
Am 16.07.2017 um 12:03 schrieb Jeff King:
> On Sun, Jul 16, 2017 at 10:07:57AM +0200, Johannes Sixt wrote:
>
>> Am 14.07.2017 um 22:08 schrieb Jeff King:
>>> The implementation on this doesn't seem overly complex. My main concerns
>>> are what we're asking from the filesystem in terms of atomicity, and
>>> what possible races there are.
>>
>> One of the failure modes is that on Windows a file cannot be deleted while
>> it is open in any process. It can happen that a compacting updater wants to
>> remove a reftable file that is still open in a reader.
>
> Good point. I think the explicit pointers I mentioned are an improvement
> there, because a compacting updater _can_ leave the file in place if the
> delete fails (and later, another compaction can clean up cruft that was
> left).
Yes, I think so, too. The pointers make things so much simpler.
> I assume that's more or less how pack deletion works on Windows.
Correct.
-- Hannes
next prev parent reply other threads:[~2017-07-16 10:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:17 reftable: new ref storage format Shawn Pearce
2017-07-13 19:32 ` Jeff King
2017-07-13 19:56 ` Stefan Beller
2017-07-13 20:35 ` Jeff King
2017-07-13 21:51 ` Eric Wong
2017-07-14 0:27 ` Shawn Pearce
2017-07-14 20:10 ` Jeff King
2017-07-14 0:11 ` Shawn Pearce
2017-07-14 14:27 ` Dave Borowitz
2017-07-14 15:31 ` Shawn Pearce
2017-07-14 20:08 ` Jeff King
2017-07-16 6:01 ` Shawn Pearce
2017-07-16 10:01 ` Jeff King
2017-07-16 8:07 ` Johannes Sixt
2017-07-16 10:03 ` Jeff King
2017-07-16 10:10 ` Johannes Sixt [this message]
2017-07-16 17:33 ` Michael Haggerty
2017-07-16 19:43 ` Shawn Pearce
2017-07-16 21:12 ` Shawn Pearce
2017-07-16 21:13 ` Dave Borowitz
2017-07-16 21:31 ` Shawn Pearce
2017-07-18 1:43 ` Michael Haggerty
2017-07-18 18:53 ` Junio C Hamano
2017-07-23 22:56 ` Shawn Pearce
2017-07-23 23:03 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2b03e6-cd29-6dec-e816-ce2c847355c4@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).