From: Eric Wong <e@80x24.org>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>,
Shawn Pearce <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: reftable: new ref storage format
Date: Thu, 13 Jul 2017 21:51:47 +0000 [thread overview]
Message-ID: <20170713215147.GA31153@starla> (raw)
In-Reply-To: <20170713203533.vcfyf5iei46g4tcf@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> I agree that a full binary search of a reftable is harder because of the
> prefix compression (it may still be possible by scanning backwards, but
> I think there are ambiguities when you land in the middle of a record,
> since there's no unambiguous end-of-record character). But I don't think
> it matters. If you binary-search to a constant-sized block, then a
> linear scan of the block is acceptable.
For a new packed-refs, I think an intrusive critbit tree would
be a good way to store refs which have many common prefixes and
I've always wanted to apply critbit to an on-disk storage
format...
Several years ago, I started writing one in Perl using
pwrite/pread to provide Message-ID <=> NNTP article number
mapping several years ago, but gave up on it out of laziness:
https://80x24.org/spew/1441508596-19511-1-git-send-email-e@80x24.org/raw
The end goal would've been to have two tries sharing the same
storage struct: one keyed by Message-ID, the other keyed by NNTP
article number (and figuring out the node using offsets like
we do with (container_of|list_entry) in list.h.
For git, being able to do an O(hashlength) prefix search based
on the object_id from the reftable would speed up decorations, I
think. And of course, the O(refnamelength) prefix search would
also apply to the refnames themselves.
next prev parent reply other threads:[~2017-07-13 21:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:17 reftable: new ref storage format Shawn Pearce
2017-07-13 19:32 ` Jeff King
2017-07-13 19:56 ` Stefan Beller
2017-07-13 20:35 ` Jeff King
2017-07-13 21:51 ` Eric Wong [this message]
2017-07-14 0:27 ` Shawn Pearce
2017-07-14 20:10 ` Jeff King
2017-07-14 0:11 ` Shawn Pearce
2017-07-14 14:27 ` Dave Borowitz
2017-07-14 15:31 ` Shawn Pearce
2017-07-14 20:08 ` Jeff King
2017-07-16 6:01 ` Shawn Pearce
2017-07-16 10:01 ` Jeff King
2017-07-16 8:07 ` Johannes Sixt
2017-07-16 10:03 ` Jeff King
2017-07-16 10:10 ` Johannes Sixt
2017-07-16 17:33 ` Michael Haggerty
2017-07-16 19:43 ` Shawn Pearce
2017-07-16 21:12 ` Shawn Pearce
2017-07-16 21:13 ` Dave Borowitz
2017-07-16 21:31 ` Shawn Pearce
2017-07-18 1:43 ` Michael Haggerty
2017-07-18 18:53 ` Junio C Hamano
2017-07-23 22:56 ` Shawn Pearce
2017-07-23 23:03 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713215147.GA31153@starla \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).