From: Shawn Pearce <spearce@spearce.org>
To: Dave Borowitz <dborowitz@google.com>
Cc: Jeff King <peff@peff.net>, git <git@vger.kernel.org>
Subject: Re: reftable: new ref storage format
Date: Fri, 14 Jul 2017 08:31:12 -0700 [thread overview]
Message-ID: <CAJo=hJupQAgYsJfeDhtVDtqoA30OpGiuR5o=ZnuRK3CaGo+ZeQ@mail.gmail.com> (raw)
In-Reply-To: <CAD0k6qRdq7n=LM7TFJYKvC4uiMMCus8kff-Lm28GiC_G-Feb2Q@mail.gmail.com>
On Fri, Jul 14, 2017 at 7:27 AM, Dave Borowitz <dborowitz@google.com> wrote:
> On Thu, Jul 13, 2017 at 8:11 PM, Shawn Pearce <spearce@spearce.org> wrote:
>> In another (Gerrit Code Review), we disable reflogs for
>> the insane refs/changes/ namespace, as nearly every reference is
>> created once, and never modified.
>
> Apologies for the tangent, but this is not true in the most recent
> Gerrit implementation. We update refs/changes/CD/ABCD/1 and
> refs/changes/CD/ABCD/meta in a single BatchRefUpdate, and we set a
> reflog message on the BatchRefUpdate instance, which updates the
> reflog for all refs in the batch. The reflog message on /meta is
> important, and arguably it's useful to be able to correlate that with
> the reflog on /1.
>
> If you think storing reflogs on patch set refs is going to be a
> problem wrt on-disk storage, we should discuss this offline :)
Reflog storage is a problem for Gerrit. It was a problem in early 2009
when servers had a lot less changes. Its going to be even more of a
problem now. Sounds like we have to support reflogs in reftable, or
something like it.
next prev parent reply other threads:[~2017-07-14 15:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:17 reftable: new ref storage format Shawn Pearce
2017-07-13 19:32 ` Jeff King
2017-07-13 19:56 ` Stefan Beller
2017-07-13 20:35 ` Jeff King
2017-07-13 21:51 ` Eric Wong
2017-07-14 0:27 ` Shawn Pearce
2017-07-14 20:10 ` Jeff King
2017-07-14 0:11 ` Shawn Pearce
2017-07-14 14:27 ` Dave Borowitz
2017-07-14 15:31 ` Shawn Pearce [this message]
2017-07-14 20:08 ` Jeff King
2017-07-16 6:01 ` Shawn Pearce
2017-07-16 10:01 ` Jeff King
2017-07-16 8:07 ` Johannes Sixt
2017-07-16 10:03 ` Jeff King
2017-07-16 10:10 ` Johannes Sixt
2017-07-16 17:33 ` Michael Haggerty
2017-07-16 19:43 ` Shawn Pearce
2017-07-16 21:12 ` Shawn Pearce
2017-07-16 21:13 ` Dave Borowitz
2017-07-16 21:31 ` Shawn Pearce
2017-07-18 1:43 ` Michael Haggerty
2017-07-18 18:53 ` Junio C Hamano
2017-07-23 22:56 ` Shawn Pearce
2017-07-23 23:03 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJo=hJupQAgYsJfeDhtVDtqoA30OpGiuR5o=ZnuRK3CaGo+ZeQ@mail.gmail.com' \
--to=spearce@spearce.org \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).