From: Shawn Pearce <spearce@spearce.org>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git <git@vger.kernel.org>
Subject: Re: reftable: new ref storage format
Date: Sun, 16 Jul 2017 14:12:07 -0700 [thread overview]
Message-ID: <CAJo=hJuOOuv_TFtqXSWUqrrGc2BT01mKj39_Jepv2cyUYF4Z4A@mail.gmail.com> (raw)
In-Reply-To: <CAJo=hJv36tYuxHuso7NrPkfE9hApGfn=iP8g_8+MeM8L91h09g@mail.gmail.com>
On Sun, Jul 16, 2017 at 12:43 PM, Shawn Pearce <spearce@spearce.org> wrote:
> On Sun, Jul 16, 2017 at 10:33 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>
>> * The tuning parameter number_of_restarts currently trades off space
>> (for the full refnames and the restart_offsets) against the need to
>> read and parse more ref_records to get the full refnames. ISTM that
>> this tradeoff could be made less painful by defining a blockwide
>> prefix that is omitted from the refnames as used in the restarts. So
>> the full refname would change from
>>
>> this_name = prior_name[0..prefix_length] + suffix
>>
>> to
>>
>> this_name = block_prefix + prior_name[0..prefix_length] + suffix
>>
>> I would expect this to allow more frequent restarts at lower space
>> cost.
>
> I've been on the fence about the value of this. It makes the search
> with restarts more difficult to implement, but does allow shrinking a
> handful of very popular prefixes like "refs/" and "refs/pulls/" in
> some blocks.
>
> An older format of reftable used only a block_prefix, and could not
> get nearly as good compression as too many blocks contained references
> with different prefixes.
I ran an experiment on my 866k ref data set. Using a block_prefix gets
less compression, and doesn't improve packing in the file. Given the
additional code complexity, it really isn't worth it:
format | size | blocks | avg ref/blk
------------------|----------|-----------|----------------
original | 28 M | 443 | 1955
block_prefix | 29 M | 464 | 1867
:-(
next prev parent reply other threads:[~2017-07-16 21:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 0:17 reftable: new ref storage format Shawn Pearce
2017-07-13 19:32 ` Jeff King
2017-07-13 19:56 ` Stefan Beller
2017-07-13 20:35 ` Jeff King
2017-07-13 21:51 ` Eric Wong
2017-07-14 0:27 ` Shawn Pearce
2017-07-14 20:10 ` Jeff King
2017-07-14 0:11 ` Shawn Pearce
2017-07-14 14:27 ` Dave Borowitz
2017-07-14 15:31 ` Shawn Pearce
2017-07-14 20:08 ` Jeff King
2017-07-16 6:01 ` Shawn Pearce
2017-07-16 10:01 ` Jeff King
2017-07-16 8:07 ` Johannes Sixt
2017-07-16 10:03 ` Jeff King
2017-07-16 10:10 ` Johannes Sixt
2017-07-16 17:33 ` Michael Haggerty
2017-07-16 19:43 ` Shawn Pearce
2017-07-16 21:12 ` Shawn Pearce [this message]
2017-07-16 21:13 ` Dave Borowitz
2017-07-16 21:31 ` Shawn Pearce
2017-07-18 1:43 ` Michael Haggerty
2017-07-18 18:53 ` Junio C Hamano
2017-07-23 22:56 ` Shawn Pearce
2017-07-23 23:03 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJo=hJuOOuv_TFtqXSWUqrrGc2BT01mKj39_Jepv2cyUYF4Z4A@mail.gmail.com' \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).