From: "Michal Suchánek" <msuchanek@suse.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Varun Varada <varuncvarada@gmail.com>,
Robert Coup <robert.coup@koordinates.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"
Date: Sun, 13 Jun 2021 18:28:02 +0200 [thread overview]
Message-ID: <20210613162802.GG8544@kitsune.suse.cz> (raw)
In-Reply-To: <60c610f04b288_41f2b208ce@natae.notmuch>
On Sun, Jun 13, 2021 at 09:06:40AM -0500, Felipe Contreras wrote:
> Michal Suchánek wrote:
> > On Sat, Jun 12, 2021 at 06:13:02PM -0500, Varun Varada wrote:
>
> > > > This will bring in reviews that focus on hairsplitting when the
> > > > formulation with 'impact' reads better than 'effect' and where the
> > > > change does not make it read any better so it should not be changed.
> > > >
> > > > It also brings in reviews of the sort that simply say that use of
> > > > 'impact' is OK, and there is no need to change.
> > >
> > > That's an "if". This, however, is a situation where multiple people
> >
> > We already received such reviews as response to your patch. It's not
> > what-if.
>
> In case you haven't been following this thread closely, you are the only
> person that says the use of "impact" is OK. One person said "impact" was
Apparently you have not followed this thread closely yourself.
> OK for him, but he didn't say anything of anybody else. Another person
> asked if they were synonyms. That's it.
>
> I say Varun should resend the patch separate from all other patches,
> explain why they aren't synonyms and mention for the record that one
> person objects to the change.
No if he really wants the thing merged he should resend the patch with
proper reasoning how replacing the word 'impact' improves the
documentation and perhaps say for the record that two people find the
word confusing.
>
> It's OK to merge patches where one person objects.
Apprantly you also missed that I am not opposed to the patch.
Best regards
Michal
>
> --
> Felipe Contreras
next prev parent reply other threads:[~2021-06-13 16:28 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 21:48 [PATCH] doc: replace jargon word "impact" with "effect"/"affect" Varun Varada
2021-04-06 9:24 ` Michal Suchánek
2021-04-06 19:36 ` Varun Varada
2021-04-06 23:01 ` Jeff King
2021-04-07 0:06 ` Varun Varada
2021-04-28 0:39 ` Varun Varada
2021-04-28 8:58 ` Michal Suchánek
2021-04-28 18:15 ` Varun Varada
2021-04-28 18:49 ` Michal Suchánek
2021-04-30 1:51 ` Varun Varada
2021-04-30 7:59 ` Michal Suchánek
2021-05-10 17:19 ` Varun Varada
2021-05-10 17:35 ` Michal Suchánek
2021-05-10 18:37 ` Varun Varada
2021-05-11 10:43 ` Michal Suchánek
2021-05-11 13:22 ` Junio C Hamano
2021-05-12 3:02 ` Felipe Contreras
2021-05-12 2:59 ` Felipe Contreras
2021-05-12 2:48 ` Felipe Contreras
2021-05-12 2:38 ` Felipe Contreras
2021-05-12 2:34 ` Felipe Contreras
2021-05-12 2:24 ` Felipe Contreras
2021-05-11 19:59 ` Felipe Contreras
2021-05-11 20:25 ` Michal Suchánek
2021-05-11 21:38 ` Varun Varada
2021-05-12 3:43 ` Felipe Contreras
2021-05-12 4:09 ` Michal Suchánek
2021-05-12 5:13 ` Felipe Contreras
2021-05-12 6:47 ` Michal Suchánek
2021-05-12 9:06 ` Felipe Contreras
2021-05-12 10:08 ` Michal Suchánek
2021-05-12 10:33 ` Michal Suchánek
2021-05-12 11:05 ` Felipe Contreras
2021-05-12 11:20 ` Michal Suchánek
2021-05-12 11:45 ` Robert P. J. Day
2021-05-12 15:19 ` Kerry, Richard
2021-05-12 16:47 ` Varun Varada
2021-05-12 17:01 ` Michal Suchánek
2021-05-12 17:32 ` Felipe Contreras
2021-05-12 18:04 ` Michal Suchánek
2021-05-12 19:42 ` Felipe Contreras
2021-05-13 7:46 ` Michal Suchánek
2021-05-13 8:28 ` Felipe Contreras
2021-05-13 8:55 ` Robert Coup
2021-05-13 9:48 ` Michal Suchánek
2021-05-13 9:59 ` Felipe Contreras
2021-05-26 23:49 ` Varun Varada
2021-05-27 11:46 ` Michal Suchánek
2021-05-27 14:08 ` Felipe Contreras
2021-05-27 14:35 ` Michal Suchánek
2021-05-27 16:43 ` Felipe Contreras
2021-06-12 23:13 ` Varun Varada
2021-06-13 11:40 ` Michal Suchánek
2021-06-13 14:06 ` Felipe Contreras
2021-06-13 16:28 ` Michal Suchánek [this message]
2021-06-13 17:12 ` Felipe Contreras
2021-05-12 22:52 ` Varun Varada
2021-05-13 6:19 ` Felipe Contreras
2021-05-12 3:21 ` Felipe Contreras
2021-05-11 19:21 ` Felipe Contreras
2021-05-11 19:57 ` Michal Suchánek
2021-05-12 3:09 ` Felipe Contreras
2021-05-12 4:11 ` Michal Suchánek
2021-05-12 5:22 ` Felipe Contreras
2021-05-12 16:39 ` Varun Varada
2021-05-13 10:40 ` Philip Oakley
2021-05-26 23:52 ` Varun Varada
2021-05-27 11:20 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210613162802.GG8544@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=robert.coup@koordinates.com \
--cc=varuncvarada@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).