From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Michal Suchánek" <msuchanek@suse.de>
Cc: Varun Varada <varuncvarada@gmail.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"
Date: Tue, 11 May 2021 22:02:37 -0500 [thread overview]
Message-ID: <609b454d33df2_678ff208f9@natae.notmuch> (raw)
In-Reply-To: <xmqq35utmmll.fsf@gitster.g>
Junio C Hamano wrote:
> As you said, lack of a specific example of what is universally
> confusing, or at least confusing to a not-so-insignificant part of
> the readership, was why this change didn't gain much support.
The original version doesn't necessarily need to be confusing.
It's sufficient that the new version is better.
> There might be one or two such places where the updated text does read
> better, but it is not a very good use of reviewers' time to find such
> needles in 700+ line haystack of a patch.
As a reviewer I will decide where I to allocate my reviewer's time,
because it's my time.
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-12 3:02 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 21:48 [PATCH] doc: replace jargon word "impact" with "effect"/"affect" Varun Varada
2021-04-06 9:24 ` Michal Suchánek
2021-04-06 19:36 ` Varun Varada
2021-04-06 23:01 ` Jeff King
2021-04-07 0:06 ` Varun Varada
2021-04-28 0:39 ` Varun Varada
2021-04-28 8:58 ` Michal Suchánek
2021-04-28 18:15 ` Varun Varada
2021-04-28 18:49 ` Michal Suchánek
2021-04-30 1:51 ` Varun Varada
2021-04-30 7:59 ` Michal Suchánek
2021-05-10 17:19 ` Varun Varada
2021-05-10 17:35 ` Michal Suchánek
2021-05-10 18:37 ` Varun Varada
2021-05-11 10:43 ` Michal Suchánek
2021-05-11 13:22 ` Junio C Hamano
2021-05-12 3:02 ` Felipe Contreras [this message]
2021-05-12 2:59 ` Felipe Contreras
2021-05-12 2:48 ` Felipe Contreras
2021-05-12 2:38 ` Felipe Contreras
2021-05-12 2:34 ` Felipe Contreras
2021-05-12 2:24 ` Felipe Contreras
2021-05-11 19:59 ` Felipe Contreras
2021-05-11 20:25 ` Michal Suchánek
2021-05-11 21:38 ` Varun Varada
2021-05-12 3:43 ` Felipe Contreras
2021-05-12 4:09 ` Michal Suchánek
2021-05-12 5:13 ` Felipe Contreras
2021-05-12 6:47 ` Michal Suchánek
2021-05-12 9:06 ` Felipe Contreras
2021-05-12 10:08 ` Michal Suchánek
2021-05-12 10:33 ` Michal Suchánek
2021-05-12 11:05 ` Felipe Contreras
2021-05-12 11:20 ` Michal Suchánek
2021-05-12 11:45 ` Robert P. J. Day
2021-05-12 15:19 ` Kerry, Richard
2021-05-12 16:47 ` Varun Varada
2021-05-12 17:01 ` Michal Suchánek
2021-05-12 17:32 ` Felipe Contreras
2021-05-12 18:04 ` Michal Suchánek
2021-05-12 19:42 ` Felipe Contreras
2021-05-13 7:46 ` Michal Suchánek
2021-05-13 8:28 ` Felipe Contreras
2021-05-13 8:55 ` Robert Coup
2021-05-13 9:48 ` Michal Suchánek
2021-05-13 9:59 ` Felipe Contreras
2021-05-26 23:49 ` Varun Varada
2021-05-27 11:46 ` Michal Suchánek
2021-05-27 14:08 ` Felipe Contreras
2021-05-27 14:35 ` Michal Suchánek
2021-05-27 16:43 ` Felipe Contreras
2021-06-12 23:13 ` Varun Varada
2021-06-13 11:40 ` Michal Suchánek
2021-06-13 14:06 ` Felipe Contreras
2021-06-13 16:28 ` Michal Suchánek
2021-06-13 17:12 ` Felipe Contreras
2021-05-12 22:52 ` Varun Varada
2021-05-13 6:19 ` Felipe Contreras
2021-05-12 3:21 ` Felipe Contreras
2021-05-11 19:21 ` Felipe Contreras
2021-05-11 19:57 ` Michal Suchánek
2021-05-12 3:09 ` Felipe Contreras
2021-05-12 4:11 ` Michal Suchánek
2021-05-12 5:22 ` Felipe Contreras
2021-05-12 16:39 ` Varun Varada
2021-05-13 10:40 ` Philip Oakley
2021-05-26 23:52 ` Varun Varada
2021-05-27 11:20 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609b454d33df2_678ff208f9@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msuchanek@suse.de \
--cc=peff@peff.net \
--cc=varuncvarada@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).