From: Taylor Blau <email@example.com> To: "brian m. carlson" <firstname.lastname@example.org>, Taylor Blau <email@example.com>, Denton Liu <firstname.lastname@example.org>, Git Mailing List <email@example.com> Subject: Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid Date: Sun, 20 Sep 2020 11:35:37 -0400 [thread overview] Message-ID: <20200920153537.GA2726066@nand.local> (raw) In-Reply-To: <20200918212609.GC67496@camp.crustytoothpaste.net> On Fri, Sep 18, 2020 at 09:26:09PM +0000, brian m. carlson wrote: > What I typically do when I write shell scripts, and which may obviate > the need for this patch is turn this: > > [ "$oid" = 0000000000000000000000000000000000000000 ] > > into this: > > echo "$oid" | grep -qsE '^0+$' > > This is slightly less efficient, but it's also backwards compatible > with older Git version assuming you have a POSIX grep. Yeah, I mostly just have no idea how common this is in the wild. If many scripts care about the null OID, then a '--null-oid' makes sense to me. But if it's only a few, then it does not. > If you still want this option, then that's fine, but please make > --null-oid take the same arguments as --show-object-format (and default > to the same value). Git will soon learn about writing SHA-1 while > storing in SHA-256, and it makes everyone's life better if we can plan > for the future by making it understand these options now. Agreed. > I'm not sure we need an empty tree and empty blob object, because it's > pretty easy to write these: > > git hash-object -t tree /dev/null > git hash-object -t blob /dev/null > > That's what I've done in some of the transition code at least. I could go either way. This for some reason seems more common to me, so I wouldn't mind making it easier for callers, but I don't care so much because what you already wrote is easy enough as-is. > -- > brian m. carlson: Houston, Texas, US Thanks, Taylor
next prev parent reply other threads:[~2020-09-20 15:37 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu 2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu 2020-09-18 16:57 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu 2020-09-18 14:11 ` Taylor Blau 2020-09-18 14:16 ` Taylor Blau 2020-09-18 18:16 ` Junio C Hamano 2020-09-18 18:21 ` Taylor Blau 2020-09-18 21:26 ` brian m. carlson 2020-09-20 4:25 ` Chris Torek 2020-09-20 18:58 ` brian m. carlson 2020-09-20 15:35 ` Taylor Blau [this message] 2020-09-20 16:03 ` Andreas Schwab 2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu 2020-09-18 17:06 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu 2020-09-18 17:08 ` Eric Sunshine 2020-09-18 21:35 ` [PATCH 0/4] sample hooks: become hash agnostic brian m. carlson 2020-09-23 9:38 ` [PATCH v2 0/3] " Denton Liu 2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu 2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu 2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu 2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200920153537.GA2726066@nand.local \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).