From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
"brian m . carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid
Date: Fri, 18 Sep 2020 11:16:54 -0700 [thread overview]
Message-ID: <xmqqy2l7kl0p.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200918141614.GC1602321@nand.local> (Taylor Blau's message of "Fri, 18 Sep 2020 10:16:14 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> In either case, I think '--zero-oid' makes more sense than '--null-oid'
> (and it matches the tests that are already written). The pair
> '--zero-oid' and '--empty-oid=<type>' make sense to me.
I am not sure rev-parse should even know about "empty-oid". An end
user or a script who wants to learn what name an empty blob has can
and should ask "git hash-object -t blob --stdin </dev/null".
I can buy --zero-oid might be handy, but don't see a pressing need
if it is merely to support our test suite and sample hooks.
Instead, something like
ZERO_OID=$(git hash-object --stdin </dev/null | tr '[0-9a-f]' '0')
should suffice, no?
Take this as a mild indifference, not as a strong rejection.
next prev parent reply other threads:[~2020-09-18 18:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu
2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu
2020-09-18 16:57 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu
2020-09-18 14:11 ` Taylor Blau
2020-09-18 14:16 ` Taylor Blau
2020-09-18 18:16 ` Junio C Hamano [this message]
2020-09-18 18:21 ` Taylor Blau
2020-09-18 21:26 ` brian m. carlson
2020-09-20 4:25 ` Chris Torek
2020-09-20 18:58 ` brian m. carlson
2020-09-20 15:35 ` Taylor Blau
2020-09-20 16:03 ` Andreas Schwab
2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu
2020-09-18 17:06 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu
2020-09-18 17:08 ` Eric Sunshine
2020-09-18 21:35 ` [PATCH 0/4] sample hooks: become hash agnostic brian m. carlson
2020-09-23 9:38 ` [PATCH v2 0/3] " Denton Liu
2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu
2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu
2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu
2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2l7kl0p.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).