From: Taylor Blau <email@example.com> To: Denton Liu <firstname.lastname@example.org> Cc: Git Mailing List <email@example.com>, "brian m . carlson" <firstname.lastname@example.org> Subject: Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid Date: Fri, 18 Sep 2020 10:16:14 -0400 [thread overview] Message-ID: <20200918141614.GC1602321@nand.local> (raw) In-Reply-To: <20200918141125.GB1602321@nand.local> On Fri, Sep 18, 2020 at 10:11:25AM -0400, Taylor Blau wrote: > Hi Denton, > > On Fri, Sep 18, 2020 at 04:19:03AM -0700, Denton Liu wrote: > > When a user needed the null OID for scripting purposes, it used to be > > very easy: hardcode 40 zeros. However, since Git started supporting > > SHA-256, this assumption became false which may break some scripts. > > Allow users to fix their broken scripts by providing users with a > > hash-agnostic method of obtaining the null OID. > > I have not been very involved in the hash transition, so please take my > comments with a grain of salt (and if they are misplaced, feel free to > ignore them). Same disclaimer above applies here, too ;-). There are a number of spots in the test suite that reference 'ZERO_OID', as well as OIDs for the empty tree and blob. Maybe the definition of those could be updated to use any new flags you do/don't introduce? I'd be just as happy if that were to occur in a different series than this, since I don't want to hold you up by adding a bunch of new things to your list. In either case, I think '--zero-oid' makes more sense than '--null-oid' (and it matches the tests that are already written). The pair '--zero-oid' and '--empty-oid=<type>' make sense to me. Thanks, Taylor
next prev parent reply other threads:[~2020-09-18 14:16 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu 2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu 2020-09-18 16:57 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu 2020-09-18 14:11 ` Taylor Blau 2020-09-18 14:16 ` Taylor Blau [this message] 2020-09-18 18:16 ` Junio C Hamano 2020-09-18 18:21 ` Taylor Blau 2020-09-18 21:26 ` brian m. carlson 2020-09-20 4:25 ` Chris Torek 2020-09-20 18:58 ` brian m. carlson 2020-09-20 15:35 ` Taylor Blau 2020-09-20 16:03 ` Andreas Schwab 2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu 2020-09-18 17:06 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu 2020-09-18 17:08 ` Eric Sunshine 2020-09-18 21:35 ` [PATCH 0/4] sample hooks: become hash agnostic brian m. carlson 2020-09-23 9:38 ` [PATCH v2 0/3] " Denton Liu 2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu 2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu 2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu 2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200918141614.GC1602321@nand.local \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).