From: "brian m. carlson" <email@example.com> To: Taylor Blau <firstname.lastname@example.org> Cc: Denton Liu <email@example.com>, Git Mailing List <firstname.lastname@example.org> Subject: Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid Date: Fri, 18 Sep 2020 21:26:09 +0000 [thread overview] Message-ID: <20200918212609.GC67496@camp.crustytoothpaste.net> (raw) In-Reply-To: <20200918141125.GB1602321@nand.local> [-- Attachment #1: Type: text/plain, Size: 2417 bytes --] On 2020-09-18 at 14:11:25, Taylor Blau wrote: > Hi Denton, > > On Fri, Sep 18, 2020 at 04:19:03AM -0700, Denton Liu wrote: > > When a user needed the null OID for scripting purposes, it used to be > > very easy: hardcode 40 zeros. However, since Git started supporting > > SHA-256, this assumption became false which may break some scripts. > > Allow users to fix their broken scripts by providing users with a > > hash-agnostic method of obtaining the null OID. > > I have not been very involved in the hash transition, so please take my > comments with a grain of salt (and if they are misplaced, feel free to > ignore them). > > This '--null-oid' thing makes me wonder exactly what it does. Yours > gives a type-less object back, but what about scripts that want the OID > of the empty blob or tree? > > Would having something like '--null-oid[=<type>]' be useful for them? On > the one hand, it seems like a thing that would be useful, but on the > other, those aren't *the* null OID when 'type' is 'blob' or 'tree'. A > more appropriate name in that case might be '--empty-oid=tree'. > > So, that's an argument that '--null-oid' and '--empty-oid[=<type>]' > should be two distinct things. I think I like that best. Do you have any > thoughts about it? So I definitely want to distinguish between the null (all-zeros) OID and the OID of an empty object, and I think using "null" and "empty" are fine. What I typically do when I write shell scripts, and which may obviate the need for this patch is turn this: [ "$oid" = 0000000000000000000000000000000000000000 ] into this: echo "$oid" | grep -qsE '^0+$' This is slightly less efficient, but it's also backwards compatible with older Git version assuming you have a POSIX grep. If you still want this option, then that's fine, but please make --null-oid take the same arguments as --show-object-format (and default to the same value). Git will soon learn about writing SHA-1 while storing in SHA-256, and it makes everyone's life better if we can plan for the future by making it understand these options now. I'm not sure we need an empty tree and empty blob object, because it's pretty easy to write these: git hash-object -t tree /dev/null git hash-object -t blob /dev/null That's what I've done in some of the transition code at least. -- brian m. carlson: Houston, Texas, US [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-09-18 21:34 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu 2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu 2020-09-18 16:57 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu 2020-09-18 14:11 ` Taylor Blau 2020-09-18 14:16 ` Taylor Blau 2020-09-18 18:16 ` Junio C Hamano 2020-09-18 18:21 ` Taylor Blau 2020-09-18 21:26 ` brian m. carlson [this message] 2020-09-20 4:25 ` Chris Torek 2020-09-20 18:58 ` brian m. carlson 2020-09-20 15:35 ` Taylor Blau 2020-09-20 16:03 ` Andreas Schwab 2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu 2020-09-18 17:06 ` Eric Sunshine 2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu 2020-09-18 17:08 ` Eric Sunshine 2020-09-18 21:35 ` [PATCH 0/4] sample hooks: become hash agnostic brian m. carlson 2020-09-23 9:38 ` [PATCH v2 0/3] " Denton Liu 2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu 2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu 2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu 2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200918212609.GC67496@camp.crustytoothpaste.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).