mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <>
To: Junio C Hamano <>
Cc: Shourya Shukla <>,,,
Subject: Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt
Date: Tue, 7 Apr 2020 01:07:09 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On 2020-04-06 at 23:46:28, Junio C Hamano wrote:
> Shourya Shukla <> writes:
> > -How do I ignore changes to a tracked file?::
> > -	Git doesn't provide a way to do this.  The reason is that if Git needs
> > +How do I ignore changes made to a tracked file?::
> > +	Git doesn't provide a way to do this. The reason is that if Git needs
> With or without 'made', I think the header says the same thing, but
> I guess it does not hurt to be explicit.

I'm fine with or without this change.  I think the original is clear to
a native English speaker, but if we think it will be easier to parse or
harder to misread with "made", then I'm in favor of the change.  I, of
course, cannot speak for how either one reads to a non-native speaker.

I'm not sure it's fair to categorize it as a "grammatical mistake",
brian m. carlson: Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2020-04-07  1:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 18:12 [PATCH 0/2] Add more issues in gitfaq Shourya Shukla
2020-04-06 18:12 ` [PATCH 1/2] gitfaq: cleanup gitfaq.txt Shourya Shukla
2020-04-06 19:06   ` Junio C Hamano
2020-04-06 23:46   ` Junio C Hamano
2020-04-07  1:07     ` brian m. carlson [this message]
2020-04-07  3:15       ` Junio C Hamano
2020-04-08 18:22     ` Pratyush Yadav
2020-04-10 18:29       ` Junio C Hamano
2020-04-06 18:12 ` [PATCH 2/2] gitfaq: append the 'Common Issues' section Shourya Shukla
2020-04-06 19:28   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).