From: Junio C Hamano <firstname.lastname@example.org> To: "brian m. carlson" <email@example.com> Cc: Shourya Shukla <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt Date: Mon, 06 Apr 2020 20:15:08 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20200407010709.GK6369@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 7 Apr 2020 01:07:09 +0000") "brian m. carlson" <email@example.com> writes: > I'm fine with or without this change. I think the original is clear to > a native English speaker, but if we think it will be easier to parse or > harder to misread with "made", then I'm in favor of the change. I, of > course, cannot speak for how either one reads to a non-native speaker. I am not a native, but if I were writing it I would probably have written without the "made", so I guess I am in slight favor of not changing this part. > I'm not sure it's fair to categorize it as a "grammatical mistake", > though. The patch certainly is an attempt to make the text better, but I agree that the patch does not correct any "mistake". Thanks.
next prev parent reply other threads:[~2020-04-07 3:15 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-06 18:12 [PATCH 0/2] Add more issues in gitfaq Shourya Shukla 2020-04-06 18:12 ` [PATCH 1/2] gitfaq: cleanup gitfaq.txt Shourya Shukla 2020-04-06 19:06 ` Junio C Hamano 2020-04-06 23:46 ` Junio C Hamano 2020-04-07 1:07 ` brian m. carlson 2020-04-07 3:15 ` Junio C Hamano [this message] 2020-04-08 18:22 ` Pratyush Yadav 2020-04-10 18:29 ` Junio C Hamano 2020-04-06 18:12 ` [PATCH 2/2] gitfaq: append the 'Common Issues' section Shourya Shukla 2020-04-06 19:28 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).