git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: git@vger.kernel.org, sandals@crustytoothpaste.net,
	emilyshaffer@google.com, martin.agren@gmail.com
Subject: Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt
Date: Mon, 06 Apr 2020 12:06:21 -0700	[thread overview]
Message-ID: <xmqqzhbov3gy.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200406181216.5340-2-shouryashukla.oo@gmail.com> (Shourya Shukla's message of "Mon, 6 Apr 2020 23:42:15 +0530")

Shourya Shukla <shouryashukla.oo@gmail.com> writes:

> The file contained a lot of whitespace errors as well as some
> grammatical mistakes. Amend them.
>
> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
> ---
>  Documentation/gitfaq.txt | 110 +++++++++++++++++++--------------------
>  1 file changed, 55 insertions(+), 55 deletions(-)
>
> diff --git a/Documentation/gitfaq.txt b/Documentation/gitfaq.txt
> index 1cf83df118..3ca16b1092 100644
> --- a/Documentation/gitfaq.txt
> +++ b/Documentation/gitfaq.txt
> @@ -23,7 +23,7 @@ Configuration
>  What should I put in `user.name`?::
>  	You should put your personal name, generally a form using a given name
>  	and family name.  For example, the current maintainer of Git uses "Junio
> -	C Hamano".  This will be the name portion that is stored in every commit
> +	C Hamano". This will be the name portion that is stored in every commit
>  	you make.
>  +
>  This configuration doesn't have any effect on authenticating to remote services;
> @@ -32,7 +32,7 @@ for that, see `credential.username` in linkgit:git-config[1].
>  [[http-postbuffer]]
>  What does `http.postBuffer` really do?::
>  	This option changes the size of the buffer that Git uses when pushing
> -	data to a remote over HTTP or HTTPS.  If the data is larger than this
> +	data to a remote over HTTP or HTTPS. If the data is larger than this
>  	size, libcurl, which handles the HTTP support for Git, will use chunked
>  	transfer encoding since it isn't known ahead of time what the size of
>  	the pushed data will be.
> @@ -40,15 +40,15 @@ What does `http.postBuffer` really do?::
>  Leaving this value at the default size is fine unless you know that either the
>  remote server or a proxy in the middle doesn't support HTTP/1.1 (which
>  introduced the chunked transfer encoding) or is known to be broken with chunked
> -data.  This is often (erroneously) suggested as a solution for generic push
> +data. This is often (erroneously) suggested as a solution for generic push
>  problems, but since almost every server and proxy supports at least HTTP/1.1,
> -raising this value usually doesn't solve most push problems.  A server or proxy
> +raising this value usually doesn't solve most push problems. A server or proxy

All of the above look useless noise.  It's not like it is turning
multiple SP after full-stop into a single SP (there is one that is
not touched in the pre-context in the first hunk, for example)---
not that such a change is worth a churn.

Please split them out and concentrate on true errors and typoes;
otherwise it is too distracting and unreviewable.

Thanks.


  reply	other threads:[~2020-04-06 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 18:12 [PATCH 0/2] Add more issues in gitfaq Shourya Shukla
2020-04-06 18:12 ` [PATCH 1/2] gitfaq: cleanup gitfaq.txt Shourya Shukla
2020-04-06 19:06   ` Junio C Hamano [this message]
2020-04-06 23:46   ` Junio C Hamano
2020-04-07  1:07     ` brian m. carlson
2020-04-07  3:15       ` Junio C Hamano
2020-04-08 18:22     ` Pratyush Yadav
2020-04-10 18:29       ` Junio C Hamano
2020-04-06 18:12 ` [PATCH 2/2] gitfaq: append the 'Common Issues' section Shourya Shukla
2020-04-06 19:28   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhbov3gy.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=shouryashukla.oo@gmail.com \
    --subject='Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).