git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: git@vger.kernel.org, sandals@crustytoothpaste.net,
	emilyshaffer@google.com, martin.agren@gmail.com
Subject: Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt
Date: Mon, 06 Apr 2020 16:46:28 -0700	[thread overview]
Message-ID: <xmqqy2r8tbxn.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200406181216.5340-2-shouryashukla.oo@gmail.com> (Shourya Shukla's message of "Mon, 6 Apr 2020 23:42:15 +0530")

Shourya Shukla <shouryashukla.oo@gmail.com> writes:

[jc: All other changes in 1/2 turned out to be removal of SP when
there were dot-SP-SP at the end of a sentence, which I am omitted
here as they were so distracting.]

> -Such a shell command can be specified by starting the option value with an
> -exclamation point.  If your password or token were stored in the `GIT_TOKEN`,
> +Such a shell command can be specified by putting an exclamation point before
> +the option. If your password or token were stored in the `GIT_TOKEN`,
>  you could run the following command to set your credential helper:

Sorry, but I am not sure how this change is an improvement.  It is
not making it worse, but it is not making it any better, at least to
me.

> -How do I ignore changes to a tracked file?::
> -	Git doesn't provide a way to do this.  The reason is that if Git needs
> +How do I ignore changes made to a tracked file?::
> +	Git doesn't provide a way to do this. The reason is that if Git needs

Ah, strike what I said about your new section on ".gitignore"; this
is already the right place to describe it.

With or without 'made', I think the header says the same thing, but
I guess it does not hurt to be explicit.

By the way, if you still want to pursue "full-stop at the end of the
sentence MUST be followed by no more than one SP", I won't stop you,
but please do so in a separate patch that has NO OTHER CHANGES.
They drown other changes out that are not mechanical and makes them
hard to review.

Thanks.

  parent reply	other threads:[~2020-04-06 23:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 18:12 [PATCH 0/2] Add more issues in gitfaq Shourya Shukla
2020-04-06 18:12 ` [PATCH 1/2] gitfaq: cleanup gitfaq.txt Shourya Shukla
2020-04-06 19:06   ` Junio C Hamano
2020-04-06 23:46   ` Junio C Hamano [this message]
2020-04-07  1:07     ` brian m. carlson
2020-04-07  3:15       ` Junio C Hamano
2020-04-08 18:22     ` Pratyush Yadav
2020-04-10 18:29       ` Junio C Hamano
2020-04-06 18:12 ` [PATCH 2/2] gitfaq: append the 'Common Issues' section Shourya Shukla
2020-04-06 19:28   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2r8tbxn.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=shouryashukla.oo@gmail.com \
    --subject='Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).