git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Thomas Gummerer <t.gummerer@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Roberto Tyley <roberto.tyley@gmail.com>
Subject: Re: [RFC/PATCH] point pull requesters to Git Git Gadget
Date: Mon, 18 Mar 2019 21:48:42 +0000	[thread overview]
Message-ID: <20190318214842.GA32487@hank.intra.tgummerer.com> (raw)
In-Reply-To: <20190318211215.GB29661@sigill.intra.peff.net>

On 03/18, Jeff King wrote:
> On Mon, Mar 18, 2019 at 11:52:54AM +0900, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > Hmm. I guess it is still an issue in GGG. This thread has identical
> > > timestamps on patches 1 and 2 (and my server received them out of order
> > > by 2 seconds, so mutt orders them wrong):
> > >
> > >   https://public-inbox.org/git/pull.163.git.gitgitgadget@gmail.com/
> > >
> > > I do still think GGG has a more feasible path forward on this particular
> > > bug, though.
> > 
> > If the MSA is rewriting the timestamp (but why?  Is the original
> > date "Wed, 13 Mar 2019 19:20:12 GMT" malformed or perhaps in the
> > future or something?), then there isn't much the sending program
> > can---'git send-email' would suffer from the same symptom.
> 
> I think this statement from me is mid-way through my discovery of the
> actual issue. Yes, if the mail server is rewriting, the best we can do
> is put in an artificial sleep.
> 
> It looks like GitGitGadget just uses normal SMTP to submit the messages.
> I wonder if normal people using gmail as their SMTP server for
> send-email also suffer from this. I've not ever noticed it, but I
> don't know how common that setup is.

I am using gmail as my SMTP server with 'git send-email', and it
doesn't look like gmail is rewriting anything there, see [*1*] for
example.  The date header looks like this:

    Date: Mon, 25 Feb 2019 23:16:04 +0000

Note the +0000 there, compared to the GMT that GitGitGadget uses.
Looking at RFC2822, that's the new version of specifying the timezone,
while GMT is only defined in the obsolete time and date section.  I
guess gmail might just not like that anymore and rewrite it.

So fixing this might not be that hard, and might not involve sleeping
while sending the patch series at all.  Changing how the date is
calculated in [*2*] might be all that's needed.

*1*: https://public-inbox.org/git/20190225231631.30507-1-t.gummerer@gmail.com/raw
*2*: https://github.com/gitgitgadget/gitgitgadget/blob/c37d58cc1581b479892a1f7d29bd16e261676c7d/lib/patch-series.ts#L427

  reply	other threads:[~2019-03-18 21:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 21:32 Jeff King
2019-03-12 23:08 ` Roberto Tyley
2019-03-13 19:34   ` Jeff King
2019-03-13 20:50   ` Johannes Schindelin
2019-03-13  1:49 ` Junio C Hamano
2019-03-13 19:39   ` Jeff King
2019-03-13 20:18     ` Jeff King
2019-03-14 11:31       ` Johannes Schindelin
2019-03-15  3:19         ` Jeff King
2019-03-15 13:42           ` Johannes Schindelin
2019-03-15 18:43             ` Jeff King
2019-03-18  2:52       ` Junio C Hamano
2019-03-18 21:12         ` Jeff King
2019-03-18 21:48           ` Thomas Gummerer [this message]
2019-03-18 21:52             ` Jeff King
2019-03-19  0:30               ` Junio C Hamano
2019-03-18 22:25           ` Ævar Arnfjörð Bjarmason
2019-03-13 21:05     ` Johannes Schindelin
2019-03-13 22:17     ` Junio C Hamano
2019-03-13  2:07 ` Junio C Hamano
2019-03-13  2:18   ` Junio C Hamano
2019-03-13 19:39     ` Jeff King
2019-03-14 12:04 ` GitGitGadget on github.com/git/git?, was " Johannes Schindelin
2019-03-14 14:46   ` Duy Nguyen
2019-03-15  3:30   ` Jeff King
2019-03-15 14:51     ` Johannes Schindelin
2019-03-15 16:28       ` Ævar Arnfjörð Bjarmason
2019-03-15 18:41         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318214842.GA32487@hank.intra.tgummerer.com \
    --to=t.gummerer@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    --cc=roberto.tyley@gmail.com \
    --subject='Re: [RFC/PATCH] point pull requesters to Git Git Gadget' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git