git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Roberto Tyley <roberto.tyley@gmail.com>
Subject: Re: [RFC/PATCH] point pull requesters to Git Git Gadget
Date: Tue, 19 Mar 2019 09:30:40 +0900	[thread overview]
Message-ID: <xmqq8sxbzowf.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190318215233.GI29661@sigill.intra.peff.net> (Jeff King's message of "Mon, 18 Mar 2019 17:52:33 -0400")

Jeff King <peff@peff.net> writes:

> On Mon, Mar 18, 2019 at 09:48:42PM +0000, Thomas Gummerer wrote:
>
>> > It looks like GitGitGadget just uses normal SMTP to submit the messages.
>> > I wonder if normal people using gmail as their SMTP server for
>> > send-email also suffer from this. I've not ever noticed it, but I
>> > don't know how common that setup is.
>> 
>> I am using gmail as my SMTP server with 'git send-email', and it
>> doesn't look like gmail is rewriting anything there, see [*1*] for
>> example.  The date header looks like this:
>> 
>>     Date: Mon, 25 Feb 2019 23:16:04 +0000
>> 
>> Note the +0000 there, compared to the GMT that GitGitGadget uses.
>> Looking at RFC2822, that's the new version of specifying the timezone,
>> while GMT is only defined in the obsolete time and date section.  I
>> guess gmail might just not like that anymore and rewrite it.
>> 
>> So fixing this might not be that hard, and might not involve sleeping
>> while sending the patch series at all.  Changing how the date is
>> calculated in [*2*] might be all that's needed.
>
> Yes, if it really is as simple as just "gmail doesn't like our date
> format, so it rewrites the header", that would be wonderful. Thanks for
> an extra data point.

I use send-email through SMTP MSA at either gmail or pobox depending
on the phase of the moon, and never noticed an issue with the
timestamp we generate.  But I noticed the "GMT" string in the
"original-date" trail in the problem message, which I didn't think
was an timestamp we would generate but somebody else might, and that
was why I quoted it in my message.  It is good that Thomas noticed
it, came up with a conjecture and a pointer to a possible fix ;-)

Thanks, all.


  reply	other threads:[~2019-03-19  0:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 21:32 [RFC/PATCH] point pull requesters to Git Git Gadget Jeff King
2019-03-12 23:08 ` Roberto Tyley
2019-03-13 19:34   ` Jeff King
2019-03-13 20:50   ` Johannes Schindelin
2019-03-13  1:49 ` Junio C Hamano
2019-03-13 19:39   ` Jeff King
2019-03-13 20:18     ` Jeff King
2019-03-14 11:31       ` Johannes Schindelin
2019-03-15  3:19         ` Jeff King
2019-03-15 13:42           ` Johannes Schindelin
2019-03-15 18:43             ` Jeff King
2019-03-18  2:52       ` Junio C Hamano
2019-03-18 21:12         ` Jeff King
2019-03-18 21:48           ` Thomas Gummerer
2019-03-18 21:52             ` Jeff King
2019-03-19  0:30               ` Junio C Hamano [this message]
2019-03-18 22:25           ` Ævar Arnfjörð Bjarmason
2019-03-13 21:05     ` Johannes Schindelin
2019-03-13 22:17     ` Junio C Hamano
2019-03-13  2:07 ` Junio C Hamano
2019-03-13  2:18   ` Junio C Hamano
2019-03-13 19:39     ` Jeff King
2019-03-14 12:04 ` GitGitGadget on github.com/git/git?, was " Johannes Schindelin
2019-03-14 14:46   ` Duy Nguyen
2019-03-15  3:30   ` Jeff King
2019-03-15 14:51     ` Johannes Schindelin
2019-03-15 16:28       ` Ævar Arnfjörð Bjarmason
2019-03-15 18:41         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8sxbzowf.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    --cc=roberto.tyley@gmail.com \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).