git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, Roberto Tyley <roberto.tyley@gmail.com>
Subject: Re: GitGitGadget on github.com/git/git?, was Re: [RFC/PATCH] point pull requesters to Git Git Gadget
Date: Fri, 15 Mar 2019 14:41:03 -0400	[thread overview]
Message-ID: <20190315184103.GB4941@sigill.intra.peff.net> (raw)
In-Reply-To: <87va0k9k6f.fsf@evledraar.gmail.com>

On Fri, Mar 15, 2019 at 05:28:08PM +0100, Ævar Arnfjörð Bjarmason wrote:

> FWIW I'd love to see it on git/git for discoverability. From the rest of
> your E-Mail it sounds like you're working on that. So just a +1.
> 
> If that doesn't work for whatever reason maybe we can amend git.git with
> this to point people to it:
> https://help.github.com/en/articles/creating-a-pull-request-template-for-your-repository
> 
> We have one in .github/PULL_REQUEST_TEMPLATE.md, maybe along with *.txt
> docs we should amend that, unless of course real GGG on git/git is
> imminent...

I think maybe you missed the patch that started this thread, which
proposes exactly that. :)

It should point people in the right direction, but of course getting GGG
directly on git/git means that they don't have to re-make their PR on a
different repo (though I guess they'd see the template while they're
making the PR, and IIRC it's no more difficult at that point than
clicking the destination repo box at the top of the page?).

> I've also noticed that for 1/1 patches it sends a 0/1, I don't do that,
> and personally wouldn't want to (just add any comments below "---").

There was some discussion of that elsewhere recently:

  https://public-inbox.org/git/20190311202441.GB18263@sigill.intra.peff.net/

> But I'm really happy it's there & useful to people, just not tempted to
> use it myself because I have a workflow I use already, and from
> observing it in action I couldn't losslessly move 100% of my submissions
> to it.

That's where I'm at, too. I doubt I'd ever use it, because I really like
my workflow. But if it is working for other people, especially people
who might otherwise be turned off of contributing, that seems like a
good thing (as long as the quality of submissions is in the same
ballpark; I think it is, and improving the tooling should keep that
moving in the right direction).

-Peff

      reply	other threads:[~2019-03-15 18:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 21:32 [RFC/PATCH] point pull requesters to Git Git Gadget Jeff King
2019-03-12 23:08 ` Roberto Tyley
2019-03-13 19:34   ` Jeff King
2019-03-13 20:50   ` Johannes Schindelin
2019-03-13  1:49 ` Junio C Hamano
2019-03-13 19:39   ` Jeff King
2019-03-13 20:18     ` Jeff King
2019-03-14 11:31       ` Johannes Schindelin
2019-03-15  3:19         ` Jeff King
2019-03-15 13:42           ` Johannes Schindelin
2019-03-15 18:43             ` Jeff King
2019-03-18  2:52       ` Junio C Hamano
2019-03-18 21:12         ` Jeff King
2019-03-18 21:48           ` Thomas Gummerer
2019-03-18 21:52             ` Jeff King
2019-03-19  0:30               ` Junio C Hamano
2019-03-18 22:25           ` Ævar Arnfjörð Bjarmason
2019-03-13 21:05     ` Johannes Schindelin
2019-03-13 22:17     ` Junio C Hamano
2019-03-13  2:07 ` Junio C Hamano
2019-03-13  2:18   ` Junio C Hamano
2019-03-13 19:39     ` Jeff King
2019-03-14 12:04 ` GitGitGadget on github.com/git/git?, was " Johannes Schindelin
2019-03-14 14:46   ` Duy Nguyen
2019-03-15  3:30   ` Jeff King
2019-03-15 14:51     ` Johannes Schindelin
2019-03-15 16:28       ` Ævar Arnfjörð Bjarmason
2019-03-15 18:41         ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315184103.GB4941@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=roberto.tyley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).